Found and eliminated several memory leaks from the OAuth library

ajaysharmalike · Jan 19, 2010 · aef0c5e · aef0c5e
1 parent c0c0416
commit aef0c5e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/OAuthConsumeriPhoneLib/OAuthConsumerSrc/OADataFetcher.m b/OAuthConsumeriPhoneLib/OAuthConsumerSrc/OADataFetcher.m
@@ -46,16 +46,16 @@ - (void)fetchDataWithRequest:(OAMutableURLRequest *)aRequest
                                                      error:&error];
 
     if (response == nil || responseData == nil || error != nil) {
-        OAServiceTicket *ticket= [[OAServiceTicket alloc] initWithRequest:request
+        OAServiceTicket *ticket= [[[OAServiceTicket alloc] initWithRequest:request
                                                                  response:response
-                                                               didSucceed:NO];
+                                                               didSucceed:NO] autorelease];
         [delegate performSelector:didFailSelector
                        withObject:ticket
                        withObject:error];
     } else {
-        OAServiceTicket *ticket = [[OAServiceTicket alloc] initWithRequest:request
+        OAServiceTicket *ticket = [[[OAServiceTicket alloc] initWithRequest:request
                                                                   response:response
-                                                                didSucceed:[(NSHTTPURLResponse *)response statusCode] < 400];
+                                                                didSucceed:[(NSHTTPURLResponse *)response statusCode] < 400] autorelease];
         [delegate performSelector:didFinishSelector
                        withObject:ticket
                        withObject:responseData];

diff --git a/OAuthConsumeriPhoneLib/OAuthConsumerSrc/OAMutableURLRequest.m b/OAuthConsumeriPhoneLib/OAuthConsumerSrc/OAMutableURLRequest.m
@@ -168,7 +168,7 @@ - (void)_generateNonce
 {
     CFUUIDRef theUUID = CFUUIDCreate(NULL);
     CFStringRef string = CFUUIDCreateString(NULL, theUUID);
-    NSMakeCollectable(theUUID);
+    CFRelease(theUUID);
     nonce = (NSString *)string;
 }
 
@@ -284,6 +284,7 @@ - (NSString *) URLEncodedString: (NSString *) string {
 																		   CFSTR("!*'();:@&=+$,/?%#[]"),
                                                                            kCFStringEncodingUTF8);
     [result autorelease];
+	CFRelease(preprocessedString);
 	return result;	
 }
 @end
diff --git a/Twitter+OAuth/Libraries & Headers/libOAuth.a b/Twitter+OAuth/Libraries & Headers/libOAuth.a