add support for hot reloading the config.yaml#100
Merged
ajnisbet merged 5 commits intoajnisbet:devfrom Oct 11, 2024
Merged
Conversation
Contributor
Author
|
@ajnisbet Any feedback? 🙈 |
Owner
|
Thanks for this Arne! It's no my radar! I've been on holiday the last month and there's a few things I'll need to tweak before merging, here's a quick review (for my later reference):
|
Contributor
Author
|
Hi, thanks for the feedback.
Done, now using pymemcache to avoid any system manipulation.
I'm a little bit puzzled how to achieve this. I played around with the
Also done now. |
Owner
|
Thanks for this work @arnesetzer ! Here's the final working code if you're interested: d1fc1a7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #99 a try to enable hot reloading for config (and therefore datasets) without rebuilding the docker image again.
What changed:
A watchdog (
/app/watcher.py) is etablish via supervisor. On a config.yaml add or change (CAVE: Due to docker limitations it won't happen if the inode changes, see: https://medium.com/@jonsbun/why-need-to-be-careful-when-mounting-single-files-into-a-docker-container-4f929340834) the watchdog is triggerd an kills the uwsgi and flushes memcached.