Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Statically positioned items don't maintain position when the page is scrolled or page dom is modified #1

Open
nyeholt opened this Issue Aug 3, 2010 · 0 comments

Comments

Projects
None yet
1 participant
Collaborator

nyeholt commented Aug 3, 2010

If the help icon is attached to an element with position: fixed or dom elements are introduced into the page which changes the location of items, the position of the help icon doesn't update to reflect where it should be positioned.

There's not a really nice way to detect any occasion when an element is added to the dom, so I've added a simple 1 second timer for repositioning elements that need to be moved due to dom updates (don't want to spam it too much because it's rare that items would be affected), and attached it to the window scroll method to handle the other instance. Can you take a look and if you can think of a better way, by all means stick it in? Otherwise, merge back to master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment