New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS X finder uses also is32 and il32 icns. #68

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@abramobagnara

abramobagnara commented Oct 6, 2017

Without this patch the list view in finder does not show the right icon for an electron-packager app.

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Oct 25, 2017

Owner

@abramobagnara

Sorry for the late reply.

is32 andil32 are in a special format with a set of colors and masks (s8mk andl8mk).

Therefore it is not enough to just add the size. The difficulty of implementation was high and I gave up in the past. However, after receiving your pull request, I decided to challenge again on issue #71.

It seems that it will take time, but it will correspond with #71.

Owner

akabekobeko commented Oct 25, 2017

@abramobagnara

Sorry for the late reply.

is32 andil32 are in a special format with a set of colors and masks (s8mk andl8mk).

Therefore it is not enough to just add the size. The difficulty of implementation was high and I gave up in the past. However, after receiving your pull request, I decided to challenge again on issue #71.

It seems that it will take time, but it will correspond with #71.

@abramobagnara

This comment has been minimized.

Show comment
Hide comment
@abramobagnara

abramobagnara Oct 25, 2017

From what I've verified with my trivial changes, is32 and il32 are enough (also without s8mk and l8mk) to have the correct icon for list view in OS X finder.

Is there a reason to make things more complex than needed? Am I missing something?

abramobagnara commented Oct 25, 2017

From what I've verified with my trivial changes, is32 and il32 are enough (also without s8mk and l8mk) to have the correct icon for list view in OS X finder.

Is there a reason to make things more complex than needed? Am I missing something?

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Oct 26, 2017

Owner

@abramobagnara

is32 and il32 are not 32 bit PNG. If simply add 16x16 and 32x32 icons, only need to support icp4 and icp5, but the #54 problem occurs.

Therefore it is necessary to support is32 and il32 correctly.

Owner

akabekobeko commented Oct 26, 2017

@abramobagnara

is32 and il32 are not 32 bit PNG. If simply add 16x16 and 32x32 icons, only need to support icp4 and icp5, but the #54 problem occurs.

Therefore it is necessary to support is32 and il32 correctly.

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Nov 21, 2017

Owner

@abramobagnara

Supporting is32 andil32 with icon-gen v1.2.0.

I also confirmed that the icon created by icon-gen was set with electron-packager and the list display of Finder was performed normally (on macOS High Sierra).

This pull request will close.

If the problem reappears please report again.

Owner

akabekobeko commented Nov 21, 2017

@abramobagnara

Supporting is32 andil32 with icon-gen v1.2.0.

I also confirmed that the icon created by icon-gen was set with electron-packager and the list display of Finder was performed normally (on macOS High Sierra).

This pull request will close.

If the problem reappears please report again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment