New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When "my project" is displayed in 1 column mode, the table protrudes #117

Closed
akabekobeko opened this Issue Sep 12, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@akabekobeko
Owner

akabekobeko commented Sep 12, 2017

When "my project" is displayed in 1 column mode, the table protrudes (from #115).

it works: now is responsive. The only mistake is that the widget on the right, when I access the site from mobile device, go out the border of his container.
I attach here the screenshot of the issue in action (1) and the screenshot of the widget as it appears on pc device.

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Sep 12, 2017

Owner

note:

The calendar widget is displayed even if the table protrudes in a theme of default. Improvement is difficult because it is caused by fixed width.

Owner

akabekobeko commented Sep 12, 2017

note:

The calendar widget is displayed even if the table protrudes in a theme of default. Improvement is difficult because it is caused by fixed width.

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Nov 6, 2017

Owner

This problem does not occur in the standard theme because body has font-size: 12px specified. In other words, it does not address folding as CSS. Because it is small, I just happen to display it.

minimalflat2 does not specify font-size for body, it is a policy to display the character size according to the environment of the end user. I do not want to change the policy to fix this issue.

Owner

akabekobeko commented Nov 6, 2017

This problem does not occur in the standard theme because body has font-size: 12px specified. In other words, it does not address folding as CSS. Because it is small, I just happen to display it.

minimalflat2 does not specify font-size for body, it is a policy to display the character size according to the environment of the end user. I do not want to change the policy to fix this issue.

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Nov 6, 2017

Owner

@pasqualedante

To fix this issue you need to reduce the font-size of body or table. However, if it is reduced with a fixed value, the unit will be displayed small with a large display, even em.

The design policy of minimalflat2 is to not fix font-size as much as possible. This is a policy to obtain optimal display on many displays.

Therefore we decided not to correspond to this issue. If the display of table overflows, please respond by reducing the character size of the Web browser or partially specifying it with User CSS (Stylish, and others).

If there are any other good ideas, please comment. The close of the issue will be judged after reading your comment.

Owner

akabekobeko commented Nov 6, 2017

@pasqualedante

To fix this issue you need to reduce the font-size of body or table. However, if it is reduced with a fixed value, the unit will be displayed small with a large display, even em.

The design policy of minimalflat2 is to not fix font-size as much as possible. This is a policy to obtain optimal display on many displays.

Therefore we decided not to correspond to this issue. If the display of table overflows, please respond by reducing the character size of the Web browser or partially specifying it with User CSS (Stylish, and others).

If there are any other good ideas, please comment. The close of the issue will be judged after reading your comment.

@akabekobeko akabekobeko modified the milestones: v1.3.5, v.NEXT Nov 6, 2017

@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Nov 6, 2017

Owner

It is likely to be fixed without changing font-size. Will use theme.js to make it like the issues table of My Page.

<div class = "autoscroll">
  <table>
  </table>
</div>

In this way you can use the scroll bar if it can not be displayed.

function setupMyPageAutoScroll () {
  $('#my-page table').each(function () {
    var parent = $(this).parent()
    if (parent.hasClass('autoscroll')) {
      return
    }

    $(this).wrap($('<div class="autoscroll"></div>'))
  })
}
Owner

akabekobeko commented Nov 6, 2017

It is likely to be fixed without changing font-size. Will use theme.js to make it like the issues table of My Page.

<div class = "autoscroll">
  <table>
  </table>
</div>

In this way you can use the scroll bar if it can not be displayed.

function setupMyPageAutoScroll () {
  $('#my-page table').each(function () {
    var parent = $(this).parent()
    if (parent.hasClass('autoscroll')) {
      return
    }

    $(this).wrap($('<div class="autoscroll"></div>'))
  })
}
@akabekobeko

This comment has been minimized.

Show comment
Hide comment
@akabekobeko

akabekobeko Nov 6, 2017

Owner

@pasqualedante

I fixed it with minimalflat2 v1.3.5. Please check it.

Owner

akabekobeko commented Nov 6, 2017

@pasqualedante

I fixed it with minimalflat2 v1.3.5. Please check it.

@pasqualedante

This comment has been minimized.

Show comment
Hide comment
@pasqualedante

pasqualedante Nov 6, 2017

@akabekobeko
yes now it works. Thanks for the fix!

pasqualedante commented Nov 6, 2017

@akabekobeko
yes now it works. Thanks for the fix!

@akabekobeko akabekobeko closed this Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment