New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Audit 2017: Unload beacon size #168

Open
nicjansma opened this Issue Dec 22, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@nicjansma

nicjansma commented Dec 22, 2017

We should investigate if we want all of the data we have on the unload beacon.

For comparison:

  • Page Load beacon, 1.530.0, all plugins enabled, blank page, Chrome: 1,876 bytes
  • Unload beacon, 1.530.0, all plugins enabled, blank page, Chrome: 1,389 bytes

That's only 487 bytes less on the unload beacon. We might want to skip things like the nt_* timestamps, which would've been part of the load beacon, and don't add much value to the unload beacon.

@bluesmoon

This comment has been minimized.

Show comment
Hide comment
@bluesmoon

bluesmoon Dec 22, 2017

we should first add NavigationTiming compression to reduce the size of both beacons.

bluesmoon commented Dec 22, 2017

we should first add NavigationTiming compression to reduce the size of both beacons.

@tollmanz

This comment has been minimized.

Show comment
Hide comment
@tollmanz

tollmanz Dec 22, 2017

I also think we should have a better system for removing data once it has been beaconed. I like how the User Timing API plugin has a mechanism to ensure that data sent on load is not also sent on unload.

Presumably, there are some cases where you may still want that data. I think it would be helpful if we exposed an easier method to remove data once it is beaconed.

tollmanz commented Dec 22, 2017

I also think we should have a better system for removing data once it has been beaconed. I like how the User Timing API plugin has a mechanism to ensure that data sent on load is not also sent on unload.

Presumably, there are some cases where you may still want that data. I think it would be helpful if we exposed an easier method to remove data once it is beaconed.

@nicjansma

This comment has been minimized.

Show comment
Hide comment
@nicjansma

nicjansma Feb 7, 2018

Good point @tollmanz . We'll soon backport an optional flag to addVar() that adds data to just the next beacon automatically, instead of having the plugin have to listen and remove the data after the next beacon.

nicjansma commented Feb 7, 2018

Good point @tollmanz . We'll soon backport an optional flag to addVar() that adds data to just the next beacon automatically, instead of having the plugin have to listen and remove the data after the next beacon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment