New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Audit 2017: Unload Beacon: NavigationTiming unload handler #170

Open
nicjansma opened this Issue Dec 22, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@nicjansma

nicjansma commented Dec 22, 2017

The NavigationTiming handler is running the main done function at unload, even if it already ran at onload.

We may want to run it again to just populate the unload event timestamp, but we probably don't need to re-run all of the code.

image

@bluesmoon

This comment has been minimized.

Show comment
Hide comment
@bluesmoon

bluesmoon Dec 22, 2017

Also consider if page_ready was fired before onload, we won't have all the details from NavTiming.

bluesmoon commented Dec 22, 2017

Also consider if page_ready was fired before onload, we won't have all the details from NavTiming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment