Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Audit 2017: Beacon: Review cookie access #173

Open
nicjansma opened this issue Dec 22, 2017 · 3 comments
Open

Performance Audit 2017: Beacon: Review cookie access #173

nicjansma opened this issue Dec 22, 2017 · 3 comments

Comments

@nicjansma
Copy link

@nicjansma nicjansma commented Dec 22, 2017

Boomerang and its plugins are getting/setting the page's cookie several times during the onload beacon preparation.

In most browsers, getting and setting the cookie is a possibly-slow operation, since it often involves reading or writing state to the disk.

RT alone calls getCookie 6 times during the load beacon preparation:

image

We should investigate if all of these gets/sets are necessary and combine/eliminate any extraneous ones.

@nicjansma

This comment has been minimized.

Copy link
Author

@nicjansma nicjansma commented Dec 31, 2018

This has been fixed in the Akamai fork and will be backported soon.

@aaarichter

This comment has been minimized.

Copy link

@aaarichter aaarichter commented Oct 20, 2019

This has been fixed in the Akamai fork and will be backported soon.

@nicjansma Do you know when this is back-ported into this repo?

@nicjansma

This comment has been minimized.

Copy link
Author

@nicjansma nicjansma commented Nov 27, 2019

There are two things we've optimized for cookies: the size, and how often we're getting/setting.

The size improvements are already available in 8eea1d7

We've also improved the number of reads/writes we do in Boomerang, and this will be backported here within a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.