add Multi-Scale support for WGAN-GP #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I 'am not sure this is right or false!! please check it , thank you
akanimax
reviewed
Sep 6, 2020
| # generate random epsilon | ||
| epsilon = th.rand((batch_size, 1, 1, 1)).to(fake_samps.device) | ||
| # generate random epsilon | ||
| epsilon = th.rand((batch_size, 1, 1, 1)).to(fake_samp.device) |
There was a problem hiding this comment.
There is a tiny issue here. The epsilon would be different for different real_samp and fake_samp, which is not intended; and perhaps also incorrect. Could you add the epsilon as another parameter to this _interp function and then select an epsilon only once outside? Basically the epsilon should be same for interpolating real and fake samples at all scales.
Rest everything looks good. 👍. Thanks.
There was a problem hiding this comment.
@Johnson-yue @akanimax any result of this? This PR is still open?
There was a problem hiding this comment.
Hi， I try to adding gp in MSG-GAN, but, it is confusion, the multi-output need gradient for D ,so it can be compute
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I 'am not sure this is right or false!! please check it , thank you