Level 3 - Mission "Prototype" #974

Closed
Silver1983 opened this Issue Jun 5, 2016 · 7 comments

Comments

Projects
None yet
4 participants
@Silver1983

Silver1983 commented Jun 5, 2016

Version: 0.95.208
Mission: Level 3 - Escort prototype (Destroyer 2) from Zeuson to Centronom.

What happend: The prototype got destroyed. Still I could complete the mission, got the thank you video and even saw the fleet "Prototype" (which was now empty) arriving at Centronom.

What should happen: The mission should fail if the Prototype got destroyed regardless of me winning the fight or not.

@akarnokd

This comment has been minimized.

Show comment
Hide comment
@akarnokd

akarnokd Jun 5, 2016

Owner

Sounds like a mission bug. Do you happen to have a save before that mission?

Owner

akarnokd commented Jun 5, 2016

Sounds like a mission bug. Do you happen to have a save before that mission?

@Silver1983

This comment has been minimized.

Show comment
Hide comment
@Silver1983

Silver1983 Jun 5, 2016

As a matter of fact I do :)

savegame.zip

As a matter of fact I do :)

savegame.zip

@akarnokd akarnokd added the help wanted label Jun 7, 2016

@akarnokd

This comment has been minimized.

Show comment
Hide comment
@akarnokd

akarnokd Jun 7, 2016

Owner

Thanks and sorry for the delayed answer. I'm quite busy now but I'll try to check and address the issue in a couple of days unless somebody else wants to look at the relevant Mission and see why the failure condition is not applied.

Owner

akarnokd commented Jun 7, 2016

Thanks and sorry for the delayed answer. I'm quite busy now but I'll try to check and address the issue in a couple of days unless somebody else wants to look at the relevant Mission and see why the failure condition is not applied.

@mansam

This comment has been minimized.

Show comment
Hide comment
@mansam

mansam Jun 7, 2016

Contributor

The mission checks to see whether the prototype fleet still exists, and it sounds like for some reason the fleet still exists after the space battle even if its contents are destroyed. I'll poke around and see if I can work out why the empty fleet doesn't get cleaned up.

Contributor

mansam commented Jun 7, 2016

The mission checks to see whether the prototype fleet still exists, and it sounds like for some reason the fleet still exists after the space battle even if its contents are destroyed. I'll poke around and see if I can work out why the empty fleet doesn't get cleaned up.

@p-smith

This comment has been minimized.

Show comment
Hide comment
@p-smith

p-smith Jun 8, 2016

Contributor

The fleet is not necessarily empty after the battle. There are also 4 fighters in the prototype fleet, so if one of them survives (even if the prototype goes down), the fleet will still exist at the end of the battle.

If the fighters die as well, the mission (correctly) fails.

Contributor

p-smith commented Jun 8, 2016

The fleet is not necessarily empty after the battle. There are also 4 fighters in the prototype fleet, so if one of them survives (even if the prototype goes down), the fleet will still exist at the end of the battle.

If the fighters die as well, the mission (correctly) fails.

@mansam

This comment has been minimized.

Show comment
Hide comment
@mansam

mansam Jun 8, 2016

Contributor

Good catch, that makes it an easy fix.

Contributor

mansam commented Jun 8, 2016

Good catch, that makes it an easy fix.

@akarnokd

This comment has been minimized.

Show comment
Hide comment
@akarnokd

akarnokd Jun 8, 2016

Owner

Thanks for the evaluation @p-smith and fix @mansam . Fix #975 merged. I'll release 209 this week (I want to see if any other simpler fixes can be done).

Owner

akarnokd commented Jun 8, 2016

Thanks for the evaluation @p-smith and fix @mansam . Fix #975 merged. I'll release 209 this week (I want to see if any other simpler fixes can be done).

@akarnokd akarnokd closed this Jun 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment