Tasos Katsoulas akatsoulas

  • Mozilla
  • Athens, Greece
  • Joined on

Organizations

@melissiproject
akatsoulas commented on pull request mozilla/mozillians#1242
@akatsoulas

Same here, please change the indentation :)

akatsoulas commented on pull request mozilla/mozillians#1242
@akatsoulas

This doesn't seem very pretty :P

akatsoulas commented on pull request mozilla/mozillians#1220
@akatsoulas

I would suggest not to change the strings if there isn't a need to because new strings need to be re-localized.

@akatsoulas

Are you sure that we don't need this?

akatsoulas commented on pull request mozilla/mozillians#1220
@akatsoulas

This link is clickable even if the user does not select the checkbox above.

@akatsoulas

The link is clickable even if the user has not select the checkbox above.

akatsoulas commented on pull request mozilla/mozillians#1220
@akatsoulas

The same is true for all the sections. Since we are breaking the profile into sections there is no need to post multiple times per section

akatsoulas commented on pull request mozilla/mozillians#1220
@akatsoulas

The Profile section should have only one update button. All the fields there should be posted into one form and not in multiple ones

akatsoulas commented on pull request mozilla/mozillians#1220
@akatsoulas

I think Skills section should be moved away from the profile and go together with Groups and rename the menu to something like Groups & Skills. It'…

@akatsoulas

I am not sure I understand what you are trying to achieve with this commit.

akatsoulas commented on pull request mozilla/mozillians#1242
@akatsoulas

How about moving skills to the groups section and change the menu name to something Skills & Groups

akatsoulas commented on pull request mozilla/mozillians#1242
@akatsoulas

I would suggest to have only one update button per menu item. For example in profile section, I believe it's overkill to post for each different se…

akatsoulas opened pull request mozilla/remo#1084
@akatsoulas
Index event name.
1 commit with 190 additions and 1 deletion
@akatsoulas
akatsoulas commented on pull request mozilla/mozillians#1242
@akatsoulas

Please use django modelforms instead of happyforms.

@akatsoulas
akatsoulas commented on pull request mozilla/mozillians#1239
@akatsoulas

Then please remove the comment a few lines above :)

akatsoulas deleted branch more-pep8-fixes at akatsoulas/mozillians
@akatsoulas
akatsoulas merged pull request mozilla/mozillians#1240
@akatsoulas
Remove unused imports.
1 commit with 1 addition and 2 deletions
akatsoulas commented on pull request mozilla/mozillians#1239
@akatsoulas

r+wc :bear:

akatsoulas commented on pull request mozilla/mozillians#1239
@akatsoulas

I would suggest to leave this as it is. Since we are ensuring that a date is always set through the forms, we should allow a none value through the…

akatsoulas commented on pull request mozilla/mozillians#1239
@akatsoulas

Please remove this comment

@akatsoulas
akatsoulas commented on pull request mozilla/mozillians#1240
@akatsoulas

@johngian r? travis is happy with these changes

akatsoulas opened pull request mozilla/mozillians#1240
@akatsoulas
Remove unused imports.
1 commit with 1 addition and 2 deletions
akatsoulas deleted branch travis-flake8 at akatsoulas/mozillians