fixed app url issue

akaunting · May 17, 2021 · bdb51a2 · bdb51a2
1 parent 03c960d
commit bdb51a2
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 11 deletions.
diff --git a/.env.example b/.env.example
@@ -5,6 +5,7 @@ APP_INSTALLED=false
 APP_KEY=
 APP_DEBUG=true
 APP_SCHEDULE_TIME="09:00"
+APP_URL=
 
 DB_CONNECTION=mysql
 DB_HOST=localhost

diff --git a/.env.testing b/.env.testing
@@ -5,6 +5,7 @@ APP_INSTALLED=true
 APP_KEY=base64:xBC+BxlC7sXhYAtpTZv8TYAHqoPgsJaXL0S5Id6BbBc=
 APP_DEBUG=true
 APP_SCHEDULE_TIME="09:00"
+APP_URL=
 
 DB_CONNECTION=sqlite
 DB_DATABASE=:memory:

diff --git a/app/Utilities/Installer.php b/app/Utilities/Installer.php
@@ -5,10 +5,10 @@
 use App\Jobs\Auth\CreateUser;
 use App\Jobs\Common\CreateCompany;
 use App\Utilities\Console;
-use Artisan;
-use Config;
-use DB;
-use File;
+use Illuminate\Support\Facades\Artisan;
+use Illuminate\Support\Facades\Config;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\File;
 use Illuminate\Support\Str;
 
 /**
@@ -232,7 +232,7 @@ public static function saveDbVariables($host, $port, $database, $username, $pass
 
     public static function createCompany($name, $email, $locale)
     {
-        dispatch_now(new CreateCompany([
+        dispatch_sync(new CreateCompany([
             'name' => $name,
             'domain' => '',
             'email' => $email,
@@ -244,7 +244,7 @@ public static function createCompany($name, $email, $locale)
 
     public static function createUser($email, $password, $locale)
     {
-        dispatch_now(new CreateUser([
+        dispatch_sync(new CreateUser([
             'name' => '',
             'email' => $email,
             'password' => $password,
@@ -258,13 +258,19 @@ public static function createUser($email, $password, $locale)
     public static function finalTouches()
     {
         // Update .env file
-        static::updateEnv([
+        $env = [
             'APP_LOCALE'            =>  session('locale'),
             'APP_INSTALLED'         =>  'true',
             'APP_DEBUG'             =>  'false',
             'FIREWALL_ENABLED'      =>  'true',
             'MODEL_CACHE_ENABLED'   =>  'true',
-        ]);
+        ];
+
+        if (!app()->runningInConsole()) {
+            $env['APP_URL'] = request()->getUriForPath('');
+        }
+
+        static::updateEnv($env);
 
         // Rename the robots.txt file
         try {

diff --git a/app/Utilities/Overrider.php b/app/Utilities/Overrider.php
@@ -50,8 +50,10 @@ protected static function loadSettings()
             app()->setLocale(setting('default.locale'));
         }
 
-        // Set app url dynamically
-        config(['app.url' => url('/')]);
+        // Set app url dynamically if empty
+        if (!config('app.url')) {
+            config(['app.url' => url('/')]);
+        }
     }
 
     protected static function loadCurrencies()

diff --git a/config/app.php b/config/app.php
@@ -55,7 +55,7 @@
     |
     */
 
-    'url' => env('APP_URL', 'http://localhost'),
+    'url' => env('APP_URL', ''),
 
     'asset_url' => env('ASSET_URL', null),