From 04bb43337f70116a8d4e310d011612eb07c1d424 Mon Sep 17 00:00:00 2001 From: roman-rezinkin Date: Sat, 9 Oct 2021 16:41:26 -0400 Subject: [PATCH 1/2] Initial Commit for input type change Signed-off-by: roman-rezinkin --- cypress/support/commands.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress/support/commands.js b/cypress/support/commands.js index 7f9f15944d7..c0265ad33a7 100644 --- a/cypress/support/commands.js +++ b/cypress/support/commands.js @@ -7,7 +7,7 @@ // commands please read more here: // https://on.cypress.io/custom-commands // *********************************************** -// +// @author Roman Rezinkin roman.rezinkin@hotmail.com // // -- This is a parent command -- // Cypress.Commands.add('login', (email, password) => { ... }) From 23135ca67b6c7b30a6d82fc3bd7acdebd8a3c8c7 Mon Sep 17 00:00:00 2001 From: roman-rezinkin Date: Sun, 10 Oct 2021 20:46:46 -0400 Subject: [PATCH 2/2] Updated fixed files Signed-off-by: roman-rezinkin --- cypress/support/commands.js | 4 ++-- cypress/support/page_objects/mainPage.js | 2 +- cypress/support/page_objects/navigation.js | 4 ++-- packages/nocodb/src/lib/public/index.html | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cypress/support/commands.js b/cypress/support/commands.js index c0265ad33a7..040bd8a99c5 100644 --- a/cypress/support/commands.js +++ b/cypress/support/commands.js @@ -52,13 +52,13 @@ Cypress.Commands.add('signinOrSignup', (_args) => { cy.wait(8000); cy.get('body').trigger('mousemove'); cy.contains('Let\'s Begin').click(); - cy.get('input[type="text"]', { timeout: 12000 }).type(args.username); + cy.get('input[type="email"]', { timeout: 12000 }).type(args.username); cy.get('input[type="password"]').type(args.password); cy.get('button:contains("SIGN UP")').click() // handle signin } else { - cy.get('input[type="text"]', { timeout: 12000 }).type(args.username); + cy.get('input[type="email"]', { timeout: 12000 }).type(args.username); cy.get('input[type="password"]').type(args.password); cy.get('button:contains("SIGN IN")').click() } diff --git a/cypress/support/page_objects/mainPage.js b/cypress/support/page_objects/mainPage.js index 349bec68158..536f54265e2 100644 --- a/cypress/support/page_objects/mainPage.js +++ b/cypress/support/page_objects/mainPage.js @@ -71,7 +71,7 @@ export class _mainPage { // Redirected to new URL, feed details // - cy.get('input[type="text"]').type(userCred.username) + cy.get('input[type="email"]').type(userCred.username) cy.get('input[type="password"]').type(userCred.password) cy.get('button:contains("SIGN UP")').click() diff --git a/cypress/support/page_objects/navigation.js b/cypress/support/page_objects/navigation.js index 0bc6ad1ddaf..dfd2e6bc412 100644 --- a/cypress/support/page_objects/navigation.js +++ b/cypress/support/page_objects/navigation.js @@ -26,7 +26,7 @@ export class _loginPage { signIn(userCredentials) { this.go(urlPool.ncUrlSignIn) - cy.get('input[type="text"]', {timeout: 6000}).type(userCredentials.username) + cy.get('input[type="email"]', {timeout: 6000}).type(userCredentials.username) cy.get('input[type="password"]').type(userCredentials.password) cy.get('button:contains("SIGN IN")').click() @@ -38,7 +38,7 @@ export class _loginPage { signUp(userCredentials) { this.go(urlPool.ncUrlSignUp) - cy.get('input[type="text"]', {timeout: 6000}).type(userCredentials.username) + cy.get('input[type="email"]', {timeout: 6000}).type(userCredentials.username) cy.get('input[type="password"]').type(userCredentials.password) cy.get('button:contains("SIGN UP")').click() diff --git a/packages/nocodb/src/lib/public/index.html b/packages/nocodb/src/lib/public/index.html index 1f5351b2fa4..8caf6ac19b4 100644 --- a/packages/nocodb/src/lib/public/index.html +++ b/packages/nocodb/src/lib/public/index.html @@ -371,7 +371,7 @@

Instant APIs on any Database