Update for node 0.6.x #39

Open
wants to merge 6 commits into
from

Projects

None yet
@caolan

require.paths has been removed in node 0.6.x, I've commented out the unshift call, but I'm not sure what purpose that line was serving. If the unshift call is essential you may need to find a way to modify the NODE_PATH and spawn a new process instead...

@Baggz

+1

@bermi

+1

@mephux

+1

@dinedal

+1

@kmiyashiro

You guys do know that this project is probably dead so someone should maintain a fork instead?

@fauzias

It's a great nice awesome project, why it shall be dead? anyone can pinpoint any maintaned fork?

@rschiavi

With require.paths commented out, seeing this error:

node.js:201
throw e; // process.nextTick error, or 'error' event on first tick
^
TypeError: Cannot call method 'runInNewContext' of undefined
at Object.loadSource (/Users/rich/dev/node_modules/dust/lib/server.js:13:19)

@g13n

Apart from commenting out/removing the require.unshift line, the following change is needed:

-Script = process.binding('evals').Script;
+Script = require("vm");

@Filirom1

This issue is 5 months old. Is this project dead ?

@kethinov

Is LinkedIn's fork basically the canonical version of dust.js now that the original can't run on current node?

@g13n
@fijiaaron

can you update the npm script to pull dust.js from linkedin if that is official now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment