a few changes/fixes we had to do in order to release 0.1 #13

Merged
merged 4 commits into from Feb 11, 2012

Projects

None yet

3 participants

@bchang
bchang commented Feb 11, 2012

No description provided.

@akeefer
Owner
akeefer commented Feb 11, 2012

Can I ask why you had to disable the tests? They run fine for me locally . . .

@bchang
bchang commented Feb 11, 2012

That was Carson. If he disabled them, maybe they weren't passing for him? I had been finding with some of the other projects that the maven-release-plugin was attempting to run tests regardless of whether you used -DskipTests or -Dmaven.test.skip=true. I didn't deal with the Tosa tests directly, but Carson and I had both been looking around the open source projects forproblematic tests we could disable just to get them deployed via the release plugin.

@akeefer
Owner
akeefer commented Feb 11, 2012

Ahhh, okay, I get it now. Those are Java tests, but they don't run if Gosu isn't initialized, so they fail when run by Maven, even though they're fine if they're run in the context of TosaSuite (which is in Gosu).

@akeefer akeefer merged commit 03726fd into akeefer:master Feb 11, 2012
@bchang
bchang commented Feb 11, 2012

Yeah, it's high on our list of priorities to be able to run Gosu tests with Maven. I think Carson has come up with a couple ideas.

@carsongross
Contributor

My current proposal for Tosa is that we just write all our tests in Gosu and take advantage of the feature that Maven currently does not run them during its test phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment