Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

a few changes/fixes we had to do in order to release 0.1 #13

Merged
merged 4 commits into from

3 participants

@bchang

No description provided.

@akeefer
Owner

Can I ask why you had to disable the tests? They run fine for me locally . . .

@bchang

That was Carson. If he disabled them, maybe they weren't passing for him? I had been finding with some of the other projects that the maven-release-plugin was attempting to run tests regardless of whether you used -DskipTests or -Dmaven.test.skip=true. I didn't deal with the Tosa tests directly, but Carson and I had both been looking around the open source projects forproblematic tests we could disable just to get them deployed via the release plugin.

@akeefer
Owner

Ahhh, okay, I get it now. Those are Java tests, but they don't run if Gosu isn't initialized, so they fail when run by Maven, even though they're fine if they're run in the context of TosaSuite (which is in Gosu).

@akeefer akeefer merged commit 03726fd into akeefer:master
@bchang

Yeah, it's high on our list of priorities to be able to run Gosu tests with Maven. I think Carson has come up with a couple ideas.

@carsongross

My current proposal for Tosa is that we just write all our tests in Gosu and take advantage of the feature that Maven currently does not run them during its test phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 11, 2012
  1. @carsongross

    Disable some tests

    carsongross authored
  2. added scm info for release plugin

    Brian Chang authored
  3. [maven-release-plugin] prepare release tosa-0.1

    Brian Chang authored
This page is out of date. Refresh to see the latest.
View
11 pom.xml
@@ -1,10 +1,9 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>org.gosu-lang.tosa</groupId>
<artifactId>tosa</artifactId>
- <version>0.1-SNAPSHOT</version>
+ <version>0.2-SNAPSHOT</version>
<packaging>jar</packaging>
<name>Tosa</name>
@@ -23,6 +22,12 @@
</repository>
</repositories>
+ <scm>
+ <connection>scm:git:git@github.com:gosu-lang/Tosa.git</connection>
+ <url>scm:git:git@github.com:gosu-lang/Tosa.git</url>
+ <developerConnection>scm:git:git@github.com:gosu-lang/Tosa.git</developerConnection>
+ </scm>
+
<dependencies>
<dependency>
<groupId>commons-dbcp</groupId>
View
2  test/tosa/impl/JoinArrayEntityCollectionImplTest.java
@@ -1,6 +1,7 @@
package tosa.impl;
import gw.lang.reflect.TypeSystem;
+import org.junit.Ignore;
import org.junit.Test;
import tosa.CachedDBObject;
import tosa.TosaDBTestBase;
@@ -22,6 +23,7 @@
* Time: 3:17 PM
* To change this template use File | Settings | File Templates.
*/
+@Ignore
public class JoinArrayEntityCollectionImplTest extends TosaDBTestBase {
private IDBObject createAndCommitFoo() {
View
2  test/tosa/impl/ReverseFkEntityCollectionImplTest.java
@@ -1,6 +1,7 @@
package tosa.impl;
import gw.lang.reflect.TypeSystem;
+import org.junit.Ignore;
import org.junit.Test;
import tosa.CachedDBObject;
import tosa.TosaDBTestBase;
@@ -18,6 +19,7 @@
* Time: 3:17 PM
* To change this template use File | Settings | File Templates.
*/
+@Ignore
public class ReverseFkEntityCollectionImplTest extends TosaDBTestBase {
private IDBObject createAndCommitBar() {
View
2  test/tosa/loader/SQLTypeTest.java
@@ -8,6 +8,7 @@
import gw.util.GosuExceptionUtil;
import org.junit.Before;
import org.junit.BeforeClass;
+import org.junit.Ignore;
import org.junit.Test;
import test.TestEnv;
import tosa.api.IDBConnection;
@@ -31,6 +32,7 @@
import static org.junit.Assert.*;
+@Ignore
public class SQLTypeTest {
@BeforeClass
View
2  test/tosa/loader/parser/SelectParsingBootstrapTest.java
@@ -1,5 +1,6 @@
package tosa.loader.parser;
+import org.junit.Ignore;
import org.junit.Test;
import tosa.loader.parser.mysql.MySQL51SQLParser;
import tosa.loader.parser.tree.SelectStatement;
@@ -9,6 +10,7 @@
import static org.junit.Assert.*;
+@Ignore
public class SelectParsingBootstrapTest {
@Test public void bootstrapSelectTest() {
QueryParser parser = new QueryParser(Token.tokenize("SELECT * FROM foo WHERE foo.bar = 10"), null);
Something went wrong with that request. Please try again.