New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Symfony behat extension to 2.0 #9416

Merged
merged 2 commits into from Feb 13, 2019

Conversation

Projects
None yet
4 participants
@arnolanglade
Copy link
Member

arnolanglade commented Jan 23, 2019

Description (for Contributor and Core Developer)

A new major version of behat symfony extension was released few days ago. It does not work the same than the previous version. First, we don't need anymore context service and cross container extension anymore. Those extension are now deprecated!

There are few changes on the DI configuration:

  • the behat contexts does not need to be tagged
  • we don't need to use __symfony__ to get a service from application container

The extension configuration change a little bit too, you should have a look to https://github.com/akeneo/pim-community-dev/pull/9416/files#diff-7bde54db60a6e933518d8b61b929edceL195

For now, we are facing some issues with the migration, an issue is open FriendsOfBehat/SymfonyExtension#54

Blocked by #9528

Definition Of Done (for Core Developer only)

Q A
Added Specs -
Added legacy Behats -
Added acceptance tests -
Added integration tests -
Changelog updated -
Review and 2 GTM Todo
Micro Demo to the PO (Story only) -
Migration script -
Tech Doc -

Todo: Pending / Work in progress
OK: Done / Validated
-: Not needed

@arnolanglade arnolanglade force-pushed the upgrade_symfony_extension branch 2 times, most recently from 8917d23 to 34b4a72 Jan 23, 2019

@arnolanglade arnolanglade added the wip label Jan 23, 2019

@ahocquard
Copy link
Contributor

ahocquard left a comment

The PIM formatter is needed for the CI.

@arnolanglade arnolanglade force-pushed the upgrade_symfony_extension branch from 34b4a72 to efa418d Feb 8, 2019

@arnolanglade arnolanglade added to review and removed wip labels Feb 8, 2019

@arnolanglade arnolanglade force-pushed the upgrade_symfony_extension branch from efa418d to 1d8c3b4 Feb 12, 2019

@arnolanglade arnolanglade changed the base branch from master to 3.0 Feb 12, 2019

@arnolanglade arnolanglade merged commit b9d868b into 3.0 Feb 13, 2019

8 checks passed

ci/circleci: back_behat_legacy Your tests passed on CircleCI!
Details
ci/circleci: back_phpunit_end_to_end Your tests passed on CircleCI!
Details
ci/circleci: back_phpunit_integration Your tests passed on CircleCI!
Details
ci/circleci: back_static_and_acceptance Your tests passed on CircleCI!
Details
ci/circleci: front_static_acceptance_and_integration Your tests passed on CircleCI!
Details
ci/circleci: pull_request/wait_for_user_approval Your job was approved on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
nestor/frozen-wizard 3.0 is warm

@arnolanglade arnolanglade deleted the upgrade_symfony_extension branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment