Add an option for file/STDIN to allow for third party chart data #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user flag is set at a time
…nd hand it to githubchart. GithubChart uses the data object directly
| @@ -9,8 +9,37 @@ OptionParser.new do |opts| | |||
| "Usage: githubchart (-u username) (-t type) path/for/new/image\n" | |||
| opts.banner << 'Supported types: ' + GithubChart.supported.join(' ') | |||
| opts.on('-uUSER', '--user=USER', 'Specify GitHub user to graph') do |user| | |||
| if options.has_key?(:input) | |||
There was a problem hiding this comment.
This should probably be "options.include? :input". has_key works, but include is the more conventional way for testing inclusion.
| exit 1 | ||
| end | ||
|
|
||
| unless (input.eql? '-') || (File.exists?(input)) |
There was a problem hiding this comment.
You may want to check "If file exists or (input equals '-' and stdin isn't a TTY", for sanity
…d collapsing long if check
…onsuming external data and checking for data creation without external data
|
Welcome to Ruby Club 👍 |
akerl
added a commit
that referenced
this pull request
Sep 2, 2014
Add an option for file/STDIN to allow for third party chart data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a -i/--input flag that takes a file or STDIN. In concert with something like fakehubstats, this would allow githubchart to create graphs of non-public or even non-git related streaks.
This is basically my first foray into Ruby, so I'm looking forward to feedback. I still need to add tests.