Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard imports are removed #19

Closed
leighmcculloch opened this Issue Feb 14, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@leighmcculloch
Copy link
Contributor

leighmcculloch commented Feb 14, 2019

Wildcard imports are removed even when they are being used. The plugin should probably ignore wildcard imports since it's difficult to determine if they're being used. I'd be happy to attempt to make a change to support this.

@leighmcculloch leighmcculloch changed the title Wildcard imports are remove Wildcard imports are removed Feb 14, 2019

@akhaku

This comment has been minimized.

Copy link
Owner

akhaku commented Feb 14, 2019

Sounds good to me, I'd love a PR! I tend to avoid star imports myself so haven't run into it

Repository owner deleted a comment from mrmrsbeck1617 Feb 14, 2019

Repository owner deleted a comment from mrmrsbeck1617 Feb 14, 2019

Repository owner deleted a comment from mrmrsbeck1617 Feb 14, 2019

Repository owner deleted a comment from mrmrsbeck1617 Feb 14, 2019

Repository owner deleted a comment from mrmrsbeck1617 Feb 14, 2019

Repository owner deleted a comment from mrmrsbeck1617 Feb 14, 2019

Repository owner deleted a comment from mrmrsbeck1617 Feb 14, 2019

@leighmcculloch

This comment has been minimized.

Copy link
Contributor Author

leighmcculloch commented Feb 14, 2019

@akhaku I opened a fix in #20. How does that look to you?

@akhaku akhaku closed this in #20 Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.