Fix potential bugs #70

wants to merge 2 commits into


None yet

2 participants

japeq commented Apr 17, 2012

A couple of fixes for potential bugs. The changes do fix any real bugs, but make the code a bit more future-proof.

Janne Kulmala added some commits Apr 17, 2012
Janne Kulmala load: Avoid unexpected behaviour in macro expansion
Macros can be dangerous if the inserted arguments are not properly
parenthesised. As macro expansion does a simple replacement, inserting
a certain expression can cause the evaluation order of the macro expression
to change.
Janne Kulmala load: Change buffer_pos to be a size_t
buffer_pos should be type size_t, because it's used to store the
current position in the read buffer. Also, it never can be negative.
@akheron akheron added a commit that closed this pull request Apr 18, 2012
@akheron Merge branch '2.3'
Closes #70.
@akheron akheron closed this in 1581f26 Apr 18, 2012
akheron commented Apr 18, 2012

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment