Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of numbers (in forced translation) #1

Closed
james-s-w-clark opened this issue Oct 9, 2017 · 5 comments
Closed

Translation of numbers (in forced translation) #1

james-s-w-clark opened this issue Oct 9, 2017 · 5 comments
Labels

Comments

@james-s-w-clark
Copy link

A text-input field has e.g. my phone number usually, and forced translation with AllTrans actually turns the numbers into words (so my phone number is like thirteen billion fifty two million.....).

Whilst it's quite amusing, it'd be great if there could be an option to omit numbers from translation (should they need translating, anyway?). Turning numbers into words means that the text-input breaks, so I have to disable AllTrans for that app and clear the cache to remember & input my number.

@akhilkedia
Copy link
Owner

akhilkedia commented Oct 10, 2017

I could add a special case for Roman Numerals (0-9), but other languages may have numbers in other forms.
This is an issue not just with numbers, but also other kinds of text in edit boxes. I have faced milder versions of this problem myself, but nothing Very broken, so never really got around to fixing this.
Perhaps a toggle to "turn off translation in all boxes in which you can input text" is a better approach?

@james-s-w-clark
Copy link
Author

Good suggestion at the end of your comment!

Having a toggle for not translating roman numerals would be handy too, as screen space is limited.

For other number systems, such as in (simplified) Chinese, I don't think you'd want to avoid translating the numbers (一,二,三,...) as they can be contained in words made of multiple characters. This could really confuse the machine translation!

@akhilkedia akhilkedia added the bug label Oct 11, 2017
@joserebelo
Copy link

I think that a toggle for not translating roman numerals would be great. "71" being translated to "Seventy one" when it should fit in a tiny space doesn't really work properly.

@da3dsoul
Copy link

da3dsoul commented Nov 27, 2017

+1 to not translate Arabic numerals. Roman numerals are I II..X. The English number system is Arabic, originating from Al-Jabr, the first documented algebra reference book.

@akhilkedia
Copy link
Owner

Latest update pushed to github solves this issue - user editable input fields are no longer translated. Will push update xposed repo version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants