Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading config fails to clean up after vimfx.addKeyOverrides() #849

Closed
6 of 11 tasks
f1u77y opened this issue Dec 15, 2016 · 2 comments
Closed
6 of 11 tasks

Reloading config fails to clean up after vimfx.addKeyOverrides() #849

f1u77y opened this issue Dec 15, 2016 · 2 comments
Labels

Comments

@f1u77y
Copy link

f1u77y commented Dec 15, 2016

  • I've searched for duplicates – also closed issues
  • I've looked at the change log
  • I've provided the below details:

VimFx version: 0.20.5
Firefox version: 53.0a1
OS: GNU/Linux
Keyboard language: en-US
Example URL (if any): None

This is … (pick one!)

  • A bug report
    • I've filled in steps to reproduce below
  • A feature request
    • I've given a detailed example below
  • Somehting else

This bug is about … (pick one!)

  • A missing hint marker on a specific page
  • VimFx not recognizing a text input on a specific page
  • Something else

Steps to reproduce:

  1. Start with an empty config
  2. Add vimfx.addKeyOverrides([() => true, ['j']]); to config
  3. Reload it
  4. Remove the line from config
  5. Reload it again
  6. Repeat steps 2-5 once more

Expected result:

j scrolls down as usual

Actual result:

j is ignored by the addon

Additional info:

There are no errors/warnings in Browser Console(with "vimfx" filter)

@lydell
Copy link
Collaborator

lydell commented Dec 15, 2016

Thanks for your clear report. Unfortunately, I cannot reproduce. (Did you press gC to reload the config file? Was there any errors in it?)

VimFx version: 0.20.5
Firefox version: 53.0a1 (2016-12-04) (64-bit)
OS: Ubuntu 16.04
Keyboard language: en-US

@f1u77y f1u77y changed the title vimfx.addKeyOverrides does not recognize "shift+key"(in "KEY" form) Reloading config fails to clean up after vimfx.addKeyOverrides() Dec 15, 2016
@f1u77y
Copy link
Author

f1u77y commented Dec 15, 2016

Oh, I thought I've found the regularity but I was very far. I've updated the issue. I'm not sure if this is the right regularity but at least I've tried to reproduce it several times on some site and it was always reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants