simplifyTestKit doc async sample #18804 #19906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the repo owners verify this patch? |
Contributor
|
OK TO TEST |
|
|
||
| //#implicit-sender | ||
| class MySpec(_system: ActorSystem) extends TestKit(_system) with ImplicitSender | ||
| class MySpec() extends TestKit(ActorSystem("MySpec")) with ImplicitSender |
Contributor
There was a problem hiding this comment.
Seems reasonable to me, as the sample does not show how to create an abstract base class for your tests, but an actual concrete test class
Contributor
|
Fixes #18804 |
Contributor
|
LGTM |
akka-ci
added
tested
|
Test PASSed. |
Contributor
|
LGTM, the |
johanandren
added a commit
that referenced
this pull request
Feb 29, 2016
…onstractor-richard-imaoka simplifyTestKit doc async sample #18804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this locally in my desktop, but assume the change will be auto-tested too?
Thanks