Make server codegen more deterministic by ensuring service methods ordering #988

[charlietsai]

From what I could tell, the .toSet transformations related to Service.methods were done to remove duplicates. Changing to a Seq via .distinct to ensure the ordering is deterministic.

Tests continue to pass with sbt test.

Also checked the example produced by

sbt "project akka-grpc-plugin-tester-scala" test
sbt "project akka-grpc-plugin-tester-java" test

and they look consistent with what was generated before.

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[akka-ci]

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

[raboof]

refs #988

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[charlietsai]

sorry for the noise, had to fix my author/comitter information

[raboof]

OK TO TEST

[raboof]

sorry for the noise, had to fix my author/comitter information

No problem, verified the CLA is now OK (even though the validator hasn't updated yet)

[raboof]

Nice, thanks!

[charlietsai]

awesome, thanks for the quick turnaround!

[raboof]

Sure, thanks for the improvement!