Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Akka rejects requests when UTF-8 charset is explicitly specified in Accept header along with `application/json` #1139
Comments
jrudolph
added the
0 - new
label
May 17, 2017
|
The behavior you describe is implemented when the That means, we might need to treat the charset parameter in the |
jrudolph
added 1 - triaged bug t:core t:model and removed 0 - new
labels
May 17, 2017
|
Maybe we could improve the line at 4758a44#diff-95adf484e1280a1b0d76142e2901b916R98, to check a mediarange charset parameter against the charset given in the fixed charset mediatype? |
Leammas
added a commit
to Leammas/akka-http
that referenced
this issue
May 17, 2017
|
|
Leammas |
6706a0e
|
|
Is the solution suggested in the PR #1140 acceptable? |
Leammas
added a commit
to Leammas/akka-http
that referenced
this issue
May 24, 2017
|
|
Leammas |
85b2a8f
|
Leammas
added a commit
to Leammas/akka-http
that referenced
this issue
May 24, 2017
|
|
Leammas |
c2adc28
|
Leammas
referenced
this issue
Jun 12, 2017
Merged
Add specific handling for `charset` param when comparing MediaTypes #1139 #1140
jrudolph
added a commit
to Leammas/akka-http
that referenced
this issue
Jun 12, 2017
|
|
Leammas + jrudolph |
af5acf5
|
jrudolph
added a commit
that referenced
this issue
Jun 12, 2017
|
|
jrudolph |
a149cf0
|
jrudolph
added this to the
10.0.8
milestone
Jun 12, 2017
|
Fixed in #1140 |
Leammas commentedMay 17, 2017
•
edited
The problem occurred after updating to 10.0.6 from 10.0.5. I've made failing unit test here:
Leammas/akka-http@194378e
According to iana the "charset" parameter should not affect compatibility.
The problem was introduced here but I'm not sure how to fix it without breaking new Accept-handling behavior