Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing creation of callback per grabbed request #1848

Merged
merged 1 commit into from Feb 12, 2018
Merged

Removing creation of callback per grabbed request #1848

merged 1 commit into from Feb 12, 2018

Conversation

kelebra
Copy link
Contributor

@kelebra kelebra commented Feb 9, 2018 •
edited

Moved creation of AsyncCallback one level up so that it won't be created each time grab(requestIn) is invoked.

Addresses comment on issue #1575

@akka-ci
Copy link

akka-ci commented Feb 9, 2018

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@raboof
Copy link
Member

raboof commented Feb 9, 2018

OK TO TEST

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Feb 9, 2018
@akka-ci
Copy link

akka-ci commented Feb 9, 2018

Test PASSed.

jrudolph
jrudolph approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not super important since we optimized async callback creation in latest akka-stream but still makes sense.

ktoso
ktoso approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktoso ktoso merged commit 61a9caf into akka:master Feb 12, 2018
@ktoso
Copy link
Member

ktoso commented Feb 12, 2018

Thanks!

@ktoso ktoso mentioned this pull request Feb 12, 2018
Closed
@jrudolph jrudolph added this to the 10.1.0-RC2 milestone Feb 12, 2018
@kelebra kelebra deleted the issue/1575 branch March 15, 2018 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.1.0-RC2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kelebra @akka-ci @raboof @ktoso @jrudolph