New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The file directives relies on broken streams config #1879

Closed
johanandren opened this Issue Feb 22, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@johanandren
Copy link
Member

johanandren commented Feb 22, 2018

The file directive has config

file-io-dispatcher = ${akka.stream.blocking-io-dispatcher}

which uses akka.stream.blocking-io-dispatcher and that was deprecated (because it was incorrect) in akka/akka#24440

I actually think the file directive should not set a dispatcher attribute at all (because it uses FileIO.fromPath(file.toPath) which uses the IODispatcher and that can be globally configured now)

@ktoso

This comment has been minimized.

Copy link
Member

ktoso commented Feb 23, 2018

(please add tags)

@shkoder

This comment has been minimized.

Copy link
Contributor

shkoder commented Mar 1, 2018

I'll take a look into this

shkoder added a commit to shkoder/akka-http that referenced this issue Mar 17, 2018

fix file-io-dispatcher akka#1879
  * use akka.stream.materializer.blocking-io-dispatcher for file IO

shkoder added a commit to shkoder/akka-http that referenced this issue Mar 17, 2018

@shkoder

This comment has been minimized.

Copy link
Contributor

shkoder commented Mar 17, 2018

#1945 introduces a basic fix while #1946 removes the dispatcher attribute. Removal of the dispatcher attribute leads to debatable consequences, that's why it's a separate PR.

shkoder added a commit to shkoder/akka-http that referenced this issue Apr 13, 2018

fix file-io-dispatcher akka#1879
  * use akka.stream.materializer.blocking-io-dispatcher for file IO

shkoder added a commit to shkoder/akka-http that referenced this issue Apr 13, 2018

shkoder added a commit to shkoder/akka-http that referenced this issue Dec 5, 2018

jrudolph added a commit that referenced this issue Dec 13, 2018

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Dec 13, 2018

I actually think the file directive should not set a dispatcher attribute at all (because it uses FileIO.fromPath(file.toPath) which uses the IODispatcher and that can be globally configured now)

That's what now was done in #1946. The previous file-io-dispatcher config setting was removed.

@jrudolph jrudolph closed this Dec 13, 2018

@jrudolph jrudolph added this to the 10.1.6 milestone Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment