Allow Http2 without negotiation/TLS #1934
Conversation
akka-ci
added
validating
|
Test PASSed. |
akka-ci
added
validating
|
Test FAILed. |
raboof
force-pushed
the
akkaHttp2withoutNegotiation
branch
from
5b00b24
to
fd6c5db
Compare
akka-ci
added
validating
|
Test FAILed. |
raboof
force-pushed
the
akkaHttp2withoutNegotiation
branch
from
fd6c5db
to
46c193f
Compare
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test PASSed. |
|
Some comments, looks like a good start though. We can merge this as we continue working on these things and polish remaining API / deduplicate later |
| } | ||
|
|
||
| class Http2(system: ExtendedActorSystem) extends Extension { | ||
| import akka.dispatch.ExecutionContexts.{ sameThreadExecutionContext ⇒ ec } |
There was a problem hiding this comment.
please pass it explicitly rather than import like this; we want to avoid using it accidentally
|
|
||
| object Http2 extends ExtensionId[Http2] with ExtensionIdProvider { | ||
| override def get(system: ActorSystem): Http2 = super.get(system) | ||
| def lookup() = Http |
| def createExtension(system: ExtendedActorSystem): Http2 = new Http2(system) | ||
| } | ||
|
|
||
| class Http2(system: ExtendedActorSystem) extends Extension { |
| import akka.dispatch.ExecutionContexts.{ sameThreadExecutionContext ⇒ ec } | ||
|
|
||
| import language.implicitConversions | ||
| private implicit def javaModelIsScalaModel[J <: AnyRef, S <: J](in: Future[J]): Future[S] = in.asInstanceOf[Future[S]] |
| import scala.compat.java8.FutureConverters._ | ||
| import scala.concurrent.Future | ||
|
|
||
| object Http2 extends ExtensionId[Http2] with ExtensionIdProvider { |
There was a problem hiding this comment.
If we're introducing it, then please mirror methods from scaladsl's Http2 or mark with huge FIXME's that it's not mirroring all methods yet
| /** | ||
| * Handle requests using HTTP/2 immediately, without any TLS or negotiation layer. | ||
| */ | ||
| def bindAndHandleRaw( |
There was a problem hiding this comment.
Raw sounds a bit weird; bindAndHandlePlainText? AFAIR that's also wording used in GRPC
There was a problem hiding this comment.
That's indeed what io.grpc.netty uses, but I found PlainText a bit weird since even though there's no encryption, it's still a binary protocol.
This approach is described in the spec as starting 'with prior knowledge', but bindAndHandleWithPriorKnowledge is weird because it's the client that has prior knowledge, not the server.
There was a problem hiding this comment.
would it be possible to make it a configuration property or a special connectionContext instead?
I'd image that you might want to easily switch between this and the real thing, perhaps running (some) tests with this and full integration tests and production with the real thing.
There was a problem hiding this comment.
That's indeed what io.grpc.netty uses, but I found PlainText a bit weird since even though there's no encryption, it's still a binary protocol.
Yeah, I've heard this argument but the general feel it conveys seems right "though shalt not use paintext in prod" ;-) Crypto wise I think plaintext is referred to non encrypted, regardless if binary or not?
There was a problem hiding this comment.
Ah, I meant this comment; Yeah trying to achieve this with a connection context would be preferable indeed, could you give it a look @raboof ?
There was a problem hiding this comment.
Basically it's the same as we have in Akka HTTP/1, where we have the plain and https one; the same could work here basically, even if we strongly recommend the https one
| @@ -91,7 +134,7 @@ class Http2Ext(private val config: Config)(implicit val system: ActorSystem) | |||
| val connections = Tcp().bind(interface, effectivePort, settings.backlog, settings.socketOptions, halfClose = false, settings.timeouts.idleTimeout) | |||
|
|
|||
| connections.mapAsyncUnordered(settings.maxConnections) { | |||
| case incoming: Tcp.IncomingConnection ⇒ | |||
| incoming: Tcp.IncomingConnection ⇒ | |||
| log: LoggingAdapter = system.log)(implicit fm: Materializer): Future[ServerBinding] = { | ||
| val effectivePort = if (port >= 0) port else 80 | ||
|
|
||
| val serverLayer: Flow[ByteString, ByteString, Future[Done]] = Flow.fromGraph(StreamUtils.fuseAggressive( |
There was a problem hiding this comment.
we can remove StreamUtils.fuseAggressive now since Akka HTTP 10.1 requires 2.5 and this is a No-Op on 2.5+
akka-ci
added
validating
raboof
force-pushed
the
akkaHttp2withoutNegotiation
branch
from
9f4447d
to
d6f6084
Compare
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test PASSed. |
Refs #1849