Support conversion between scaladsl.Uri and javadsl.Uri #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test FAILed. |
|
The new method is marked as possible incompatibility Ok to add to create |
|
Yes it's fine to add since the model is assumed "we may add methods there, do not inherit from it" |
akka-ci
added
validating
|
Test PASSed. |
ktoso
reviewed
Mar 19, 2018
| @@ -186,6 +192,13 @@ public static Uri create(String uri) { | |||
| return new JavaUri(akka.http.scaladsl.model.Uri.apply(uri)); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns an Uri wrapping the scaladsl representation. | |||
There was a problem hiding this comment.
don't explain the implementation details :-)
"Returns the Java DSL representation of an Scala DSL Uri" :)
ktoso
reviewed
Mar 19, 2018
| @@ -171,6 +171,12 @@ | |||
| */ | |||
| public abstract String getPathString(); | |||
|
|
|||
| /** | |||
| * Returns the scaladsl view of this instance | |||
There was a problem hiding this comment.
same as bellow, explain that it mirrors the APIs, no impl details in such methods pls
ktoso
reviewed
Mar 19, 2018
akka-ci
added
validating
|
Test PASSed. |
ktoso
pushed a commit
to ktoso/akka-http
that referenced
this pull request
Mar 22, 2018
* Support conversion between scaladsl.Uri and javadsl.Uri * Exclude javadsl.moduel.Uri.asScala from MiMa * Rephrase method documentation
ktoso
pushed a commit
that referenced
this pull request
Mar 22, 2018
* Support conversion between scaladsl.Uri and javadsl.Uri * Exclude javadsl.moduel.Uri.asScala from MiMa * Rephrase method documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
javadsl.model.Uri.asScala()Adds
static javadsl.model.Uri.create(scaladsl.model.Uri)Removes the internal conversion method from
akka.http.impl.util.Util.Fixes #1949