Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaDSL is missing ServerSentEvent.heartbeat #2187

Closed
johanandren opened this Issue Sep 4, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@johanandren
Copy link
Member

johanandren commented Sep 4, 2018

In the Scala DSL there is a public heartbeat val (which I think can be used from Java as well, given the inheritance) but there is no such value/factory in the Java DSL.

@jlprat

This comment has been minimized.

Copy link
Member

jlprat commented Sep 5, 2018

Picking this one :)

@jlprat jlprat self-assigned this Sep 5, 2018

@jlprat jlprat added 3 - in progress and removed 1 - triaged labels Sep 5, 2018

jlprat added a commit to jlprat/akka-http that referenced this issue Sep 5, 2018

Add missing ServerSentEvent.heartbeat for JavaDSL akka#2187
Refs: akka#2187
Added tests for both Java and Scala DSL for heartbeat

raboof added a commit that referenced this issue Sep 5, 2018

Add missing ServerSentEvent.heartbeat for JavaDSL #2187 (#2197)
Refs: #2187
Added tests for both Java and Scala DSL for heartbeat

@raboof raboof added this to the 10.1.5 milestone Sep 5, 2018

@raboof raboof closed this Sep 5, 2018

Synesso added a commit to Synesso/akka-http that referenced this issue Sep 17, 2018

Add missing ServerSentEvent.heartbeat for JavaDSL akka#2187 (akka#2197)
Refs: akka#2187
Added tests for both Java and Scala DSL for heartbeat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.