New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Akka dependency provided for the akka-http-testkit project #2262

Closed
jlprat opened this Issue Oct 23, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@jlprat
Copy link
Member

jlprat commented Oct 23, 2018

Currently, all main akka-http projects have a provided dependency with the Akka library. This is true for all projects except for the akka-http-testkit one.
The implication of this is that, if only the akka-http-testkit dependency is added, and not the akka-streams-testkit one, the akka version checker will fail and complain about different versions.

@jrudolph jrudolph added 1 - triaged and removed 1 - triaged labels Oct 23, 2018

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Oct 23, 2018

I wonder if that was by purpose because we don't really care that much for the testkit because it will be used only in tests where we don't expect any dependency problems (which was the reason to make it provided otherwise). On the other hand, it shouldn't matter, so maybe we can mark it provided there as well.

@jlprat

This comment has been minimized.

Copy link
Member

jlprat commented Oct 23, 2018

I will take this one. I think is better to also mark it as provided for the sake of consistency.

jlprat added a commit to jlprat/akka-http that referenced this issue Oct 23, 2018

jrudolph added a commit that referenced this issue Oct 24, 2018

@jrudolph jrudolph added this to the 10.1.6 milestone Oct 24, 2018

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Oct 24, 2018

Fixed by #2263.

@jrudolph jrudolph closed this Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment