New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding woff2 to MediaTypes #2330

Closed
pme123 opened this Issue Dec 19, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@pme123
Copy link

pme123 commented Dec 19, 2018

Woff2 is not recognized as MediaType, because its entry is missing in MediaTypes.

In:
akka.http.scaladsl.model.MediaTypes

Around Line 333 something like this should be added:

val `application/font-woff2`  = abin("font-woff2", NotCompressible, "woff2")
@raboof

This comment has been minimized.

Copy link
Member

raboof commented Dec 19, 2018

Shouldn't that be font/woff2? (https://dev.w3.org/webfonts/WOFF2/spec/)

A PR adding it would be appreciated, but for the time being you can add it to your application as a custom media type as described in https://doc.akka.io/docs/akka-http/current/common/http-model.html#registering-custom-media-types. Does that work for you?

@pme123

This comment has been minimized.

Copy link

pme123 commented Dec 19, 2018

font/woff2 I am not sure, I just found application/font-woff2 and it solved my problem.

I use akka-http within play - Does this description work as well?

@raboof

This comment has been minimized.

Copy link
Member

raboof commented Dec 19, 2018

I'm not sure how this works in Play - that might be a good question for https://discuss.playframework.com?

@pme123

This comment has been minimized.

Copy link

pme123 commented Dec 19, 2018

ok, thanks for the support.

ashishkujoy added a commit to ashishkujoy/akka-http that referenced this issue Dec 20, 2018

akka#2330 Deprecated application/font-woff2 media type and added WOFF…
… File Format 1 and 2 with font as main type

ashishkujoy added a commit to ashishkujoy/akka-http that referenced this issue Dec 21, 2018

ashishkujoy added a commit to ashishkujoy/akka-http that referenced this issue Dec 21, 2018

raboof added a commit that referenced this issue Jan 2, 2019

@raboof raboof added this to the 10.1.7 milestone Jan 3, 2019

@raboof raboof closed this Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment