New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Server-Sent Events by including Akka SSE #669

Closed
hseeberger opened this Issue Dec 20, 2016 · 13 comments

Comments

Projects
None yet
4 participants
@hseeberger
Contributor

hseeberger commented Dec 20, 2016

Please discuss.

@hseeberger

This comment has been minimized.

Show comment
Hide comment

@ktoso ktoso added this to the 10.0.x milestone Dec 21, 2016

@ktoso ktoso added the discuss label Dec 21, 2016

@hseeberger

This comment has been minimized.

Show comment
Hide comment
@hseeberger

hseeberger Dec 30, 2016

Contributor

I have just released Akka SSE 2.0.0. The idea is that it could be moved in as is (except for shuffling package names and adding non-Scaladoc documentation), so please take a look at the design and implementation.

Contributor

hseeberger commented Dec 30, 2016

I have just released Akka SSE 2.0.0. The idea is that it could be moved in as is (except for shuffling package names and adding non-Scaladoc documentation), so please take a look at the design and implementation.

@ktoso ktoso self-assigned this Dec 30, 2016

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Dec 30, 2016

Member

Great, thanks a lot Heiko. I'll get to it next week I think, attempting to stay offline for a few days now :)
In general I'm in favour of pulling it in, seems you worked on javadsl as well so let's see if we're all good there. Will comment there or here somehow hm hm

Member

ktoso commented Dec 30, 2016

Great, thanks a lot Heiko. I'll get to it next week I think, attempting to stay offline for a few days now :)
In general I'm in favour of pulling it in, seems you worked on javadsl as well so let's see if we're all good there. Will comment there or here somehow hm hm

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Jan 9, 2017

Member

Hope to get to it this week, we're still halfed with much of the team on holidays. Sorry for the delay.

Member

ktoso commented Jan 9, 2017

Hope to get to it this week, we're still halfed with much of the team on holidays. Sorry for the delay.

@hseeberger

This comment has been minimized.

Show comment
Hide comment
@hseeberger

hseeberger Jan 14, 2017

Contributor

Any progress here?

Contributor

hseeberger commented Jan 14, 2017

Any progress here?

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Jan 14, 2017

Member
Member

ktoso commented Jan 14, 2017

@hseeberger

This comment has been minimized.

Show comment
Hide comment
@hseeberger

hseeberger Jan 15, 2017

Contributor

Sure, I could create a PR. But that's a lot of work and therefore I'd like to see a general thumbs up to the idea of including SSE first.

Contributor

hseeberger commented Jan 15, 2017

Sure, I could create a PR. But that's a lot of work and therefore I'd like to see a general thumbs up to the idea of including SSE first.

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Jan 15, 2017

Member

As you know since a long time, there is a thumbs up ;-)
We'd still ask for help in maintaining it of course though, but I think that's self explanatory.

Member

ktoso commented Jan 15, 2017

As you know since a long time, there is a thumbs up ;-)
We'd still ask for help in maintaining it of course though, but I think that's self explanatory.

@hseeberger

This comment has been minimized.

Show comment
Hide comment
@hseeberger

hseeberger Jan 16, 2017

Contributor

Sounds great! Will make a PR as soon as I can find some time.

Contributor

hseeberger commented Jan 16, 2017

Sounds great! Will make a PR as soon as I can find some time.

@hseeberger

This comment has been minimized.

Show comment
Hide comment
@hseeberger

hseeberger Jan 16, 2017

Contributor

(didn't check the thumbs-up, now there are four ;-))

Contributor

hseeberger commented Jan 16, 2017

(didn't check the thumbs-up, now there are four ;-))

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Jan 16, 2017

Member

Excellent, thanks 👍

Member

ktoso commented Jan 16, 2017

Excellent, thanks 👍

@Gabology

This comment has been minimized.

Show comment
Hide comment
@Gabology

Gabology Apr 6, 2017

Contributor

@hseeberger Any chance you could submit that PR soon? Looking to use this for a project and I admit it would be easiest if this was bundled directly with akka-http. Also makes sense as they are already supporting WebSockets :) .

Contributor

Gabology commented Apr 6, 2017

@hseeberger Any chance you could submit that PR soon? Looking to use this for a project and I admit it would be easiest if this was bundled directly with akka-http. Also makes sense as they are already supporting WebSockets :) .

@hseeberger

This comment has been minimized.

Show comment
Hide comment
@hseeberger

hseeberger Apr 7, 2017

Contributor

@OverlyExcessive I'm too busy, but using akka-sse should be a no-brainer.

Contributor

hseeberger commented Apr 7, 2017

@OverlyExcessive I'm too busy, but using akka-sse should be a no-brainer.

@ktoso ktoso referenced this issue May 12, 2017

Merged

Include Akka SSE #1116

@ktoso ktoso added 3 - in progress and removed 1 - triaged labels May 12, 2017

@jrudolph jrudolph closed this in 5321d37 Jun 14, 2017

@jrudolph jrudolph modified the milestones: 10.0.8, 10.0.x Jun 14, 2017

tomrf1 added a commit to tomrf1/akka-http that referenced this issue Aug 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment