Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Server-Sent Events by including Akka SSE #669

Closed
hseeberger opened this issue Dec 20, 2016 · 13 comments
Closed

Add support for Server-Sent Events by including Akka SSE #669

hseeberger opened this issue Dec 20, 2016 · 13 comments
Assignees
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding 3 - in progress Someone is working on this ticket discuss Tickets that need some discussion before proceeding
Milestone

Comments

@hseeberger
Copy link
Contributor

Please discuss.

@hseeberger
Copy link
Contributor Author

Akka SSE: https://github.com/hseeberger/akka-sse

@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding labels Dec 21, 2016
@ktoso ktoso added this to the 10.0.x milestone Dec 21, 2016
@ktoso ktoso added the discuss Tickets that need some discussion before proceeding label Dec 21, 2016
@hseeberger
Copy link
Contributor Author

I have just released Akka SSE 2.0.0. The idea is that it could be moved in as is (except for shuffling package names and adding non-Scaladoc documentation), so please take a look at the design and implementation.

@ktoso ktoso self-assigned this Dec 30, 2016
@ktoso
Copy link
Member

ktoso commented Dec 30, 2016

Great, thanks a lot Heiko. I'll get to it next week I think, attempting to stay offline for a few days now :)
In general I'm in favour of pulling it in, seems you worked on javadsl as well so let's see if we're all good there. Will comment there or here somehow hm hm

@ktoso
Copy link
Member

ktoso commented Jan 9, 2017

Hope to get to it this week, we're still halfed with much of the team on holidays. Sorry for the delay.

@hseeberger
Copy link
Contributor Author

Any progress here?

@ktoso
Copy link
Member

ktoso commented Jan 14, 2017 via email

@hseeberger
Copy link
Contributor Author

Sure, I could create a PR. But that's a lot of work and therefore I'd like to see a general thumbs up to the idea of including SSE first.

@ktoso
Copy link
Member

ktoso commented Jan 15, 2017

As you know since a long time, there is a thumbs up ;-)
We'd still ask for help in maintaining it of course though, but I think that's self explanatory.

@hseeberger
Copy link
Contributor Author

Sounds great! Will make a PR as soon as I can find some time.

@hseeberger
Copy link
Contributor Author

(didn't check the thumbs-up, now there are four ;-))

@ktoso
Copy link
Member

ktoso commented Jan 16, 2017

Excellent, thanks 👍

@Gabology
Copy link
Contributor

Gabology commented Apr 6, 2017

@hseeberger Any chance you could submit that PR soon? Looking to use this for a project and I admit it would be easiest if this was bundled directly with akka-http. Also makes sense as they are already supporting WebSockets :) .

@hseeberger
Copy link
Contributor Author

@OverlyExcessive I'm too busy, but using akka-sse should be a no-brainer.

@ktoso ktoso added 3 - in progress Someone is working on this ticket and removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels May 12, 2017
@jrudolph jrudolph modified the milestones: 10.0.8, 10.0.x Jun 14, 2017
tomrf1 pushed a commit to tomrf1/akka-http that referenced this issue Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding 3 - in progress Someone is working on this ticket discuss Tickets that need some discussion before proceeding
Projects
None yet
Development

No branches or pull requests

4 participants