Add support for Server-Sent Events by including Akka SSE #669

Closed
hseeberger opened this Issue Dec 20, 2016 · 13 comments

Comments

Projects
None yet
4 participants
Contributor

hseeberger commented Dec 20, 2016

Please discuss.

ktoso added this to the 10.0.x milestone Dec 21, 2016

ktoso added the discuss label Dec 21, 2016

Contributor

hseeberger commented Dec 30, 2016

I have just released Akka SSE 2.0.0. The idea is that it could be moved in as is (except for shuffling package names and adding non-Scaladoc documentation), so please take a look at the design and implementation.

ktoso self-assigned this Dec 30, 2016

Owner

ktoso commented Dec 30, 2016

Great, thanks a lot Heiko. I'll get to it next week I think, attempting to stay offline for a few days now :)
In general I'm in favour of pulling it in, seems you worked on javadsl as well so let's see if we're all good there. Will comment there or here somehow hm hm

Owner

ktoso commented Jan 9, 2017

Hope to get to it this week, we're still halfed with much of the team on holidays. Sorry for the delay.

Contributor

hseeberger commented Jan 14, 2017

Any progress here?

Owner

ktoso commented Jan 14, 2017

Contributor

hseeberger commented Jan 15, 2017

Sure, I could create a PR. But that's a lot of work and therefore I'd like to see a general thumbs up to the idea of including SSE first.

Owner

ktoso commented Jan 15, 2017 edited

As you know since a long time, there is a thumbs up ;-)
We'd still ask for help in maintaining it of course though, but I think that's self explanatory.

Contributor

hseeberger commented Jan 16, 2017

Sounds great! Will make a PR as soon as I can find some time.

Contributor

hseeberger commented Jan 16, 2017

(didn't check the thumbs-up, now there are four ;-))

Owner

ktoso commented Jan 16, 2017

Excellent, thanks 👍

@hseeberger Any chance you could submit that PR soon? Looking to use this for a project and I admit it would be easiest if this was bundled directly with akka-http. Also makes sense as they are already supporting WebSockets :) .

Contributor

hseeberger commented Apr 7, 2017

@OverlyExcessive I'm too busy, but using akka-sse should be a no-brainer.

ktoso referenced this issue May 12, 2017

Merged

Include Akka SSE #1116

@ktoso ktoso added 3 - in progress and removed 1 - triaged labels May 12, 2017

jrudolph closed this in 5321d37 Jun 14, 2017

@jrudolph jrudolph modified the milestone: 10.0.8, 10.0.x Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment