New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP status code 418 #1206

Merged
merged 2 commits into from Jun 26, 2017

Conversation

Projects
None yet
7 participants
@ametrocavich
Contributor

ametrocavich commented Jun 16, 2017

Added support for status code 418 according to https://tools.ietf.org/html/rfc2324

Add HTTP status code 418
Added support for status code 418 according to https://tools.ietf.org/html/rfc2324
@lightbend-cla-validator

This comment has been minimized.

Show comment
Hide comment
@lightbend-cla-validator

lightbend-cla-validator Jun 16, 2017

Hi @ametrocavich,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

Hi @ametrocavich,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@akka-ci

This comment has been minimized.

Show comment
Hide comment
@akka-ci

akka-ci Jun 16, 2017

Collaborator

Can one of the repo owners verify this patch?

Collaborator

akka-ci commented Jun 16, 2017

Can one of the repo owners verify this patch?

@ametrocavich

This comment has been minimized.

Show comment
Hide comment
@ametrocavich

ametrocavich Jun 16, 2017

Contributor

I signed the CLA

Contributor

ametrocavich commented Jun 16, 2017

I signed the CLA

@jlprat

This comment has been minimized.

Show comment
Hide comment
@jlprat

jlprat Jun 16, 2017

Member

OK TO TEST

Member

jlprat commented Jun 16, 2017

OK TO TEST

@akka-ci akka-ci added validating tested and removed validating labels Jun 16, 2017

@akka-ci

This comment has been minimized.

Show comment
Hide comment
@akka-ci

akka-ci Jun 16, 2017

Collaborator

Test PASSed.

Collaborator

akka-ci commented Jun 16, 2017

Test PASSed.

@@ -142,6 +142,7 @@ object StatusCodes extends ObjectRegistry[Int, StatusCode] {
val UnsupportedMediaType = reg(c(415)("Unsupported Media Type", "The request entity has a media type which the server or resource does not support."))
val RequestedRangeNotSatisfiable = reg(c(416)("Requested Range Not Satisfiable", "The client has asked for a portion of the file, but the server cannot supply that portion."))
val ExpectationFailed = reg(c(417)("Expectation Failed", "The server cannot meet the requirements of the Expect request-header field."))
val ImATeapot = reg(c(418)("I'm a teapot", "The resulting entity body MAY be short and stout."))

This comment has been minimized.

@ktoso

ktoso Jun 17, 2017

Member

If this is seriously meant to get in then the PR is missing Java API ;-)
You'd have to mirror it in javadsl/model/StatusCodes

@ktoso

ktoso Jun 17, 2017

Member

If this is seriously meant to get in then the PR is missing Java API ;-)
You'd have to mirror it in javadsl/model/StatusCodes

This comment has been minimized.

@ametrocavich

ametrocavich Jun 19, 2017

Contributor

Done :)

@ametrocavich

ametrocavich Jun 19, 2017

Contributor

Done :)

@akka-ci

This comment has been minimized.

Show comment
Hide comment
@akka-ci

akka-ci Jun 19, 2017

Collaborator

Test PASSed.

Collaborator

akka-ci commented Jun 19, 2017

Test PASSed.

@jlprat

I guess, for the sake of implementing the specs, LGTM :?)

@jrudolph

This comment has been minimized.

Show comment
Hide comment
@jrudolph

jrudolph Jun 26, 2017

Member

Great first addition, @ametrocavich ;) ☕️ 🍵

Member

jrudolph commented Jun 26, 2017

Great first addition, @ametrocavich ;) ☕️ 🍵

@jrudolph jrudolph merged commit a46958b into akka:master Jun 26, 2017

3 checks passed

Jenkins PR Validation Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@jrudolph jrudolph added this to the 10.0.9 milestone Jun 26, 2017

@ametrocavich ametrocavich deleted the ametrocavich:patch-1 branch Jun 27, 2017

tomrf1 added a commit to tomrf1/akka-http that referenced this pull request Aug 13, 2017

Add HTTP status code 418 (#1206)
Added support for status code 418 according to https://tools.ietf.org/html/rfc2324
@btomala

This comment has been minimized.

Show comment
Hide comment
@btomala

btomala May 8, 2018

Contributor

This status is missing in the 10.1.1 version. Is it regression or deliberate action?

Contributor

btomala commented May 8, 2018

This status is missing in the 10.1.1 version. Is it regression or deliberate action?

@ktoso

This comment has been minimized.

Show comment
Hide comment
Member

ktoso commented May 8, 2018

@btomala

This comment has been minimized.

Show comment
Hide comment
@btomala

btomala May 8, 2018

Contributor

Sorry, my mistake. I checked twice but on the master @ametrocavich fork. And IntelliJ said it is missing - strange, probably import wrong source code. Sorry for the inconvenience.

Contributor

btomala commented May 8, 2018

Sorry, my mistake. I checked twice but on the master @ametrocavich fork. And IntelliJ said it is missing - strange, probably import wrong source code. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment