New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=htc replace usage of `RuleNotFoundException` by introducing explicit result ADT #1424

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
3 participants
@jrudolph
Member

jrudolph commented Sep 14, 2017

Before every attempt to parse an unknown (i.e. not modeled) header would
end up in throwing and catching an exception. This does not really make
sense as parboiled already provides for delivering these signals without
an exception.

Refs playframework/playframework#7822

@akka-ci

This comment has been minimized.

Show comment
Hide comment
@akka-ci

akka-ci Sep 14, 2017

Collaborator

Test FAILed.

Collaborator

akka-ci commented Sep 14, 2017

Test FAILed.

@jrudolph

This comment has been minimized.

Show comment
Hide comment
@jrudolph

jrudolph Sep 14, 2017

Member

Added missing mima filters.

Member

jrudolph commented Sep 14, 2017

Added missing mima filters.

@akka-ci

This comment has been minimized.

Show comment
Hide comment
@akka-ci

akka-ci Sep 14, 2017

Collaborator

Test FAILed.

Collaborator

akka-ci commented Sep 14, 2017

Test FAILed.

@akka-ci

This comment has been minimized.

Show comment
Hide comment
@akka-ci

akka-ci Sep 14, 2017

Collaborator

Test PASSed.

Collaborator

akka-ci commented Sep 14, 2017

Test PASSed.

@raboof

raboof approved these changes Sep 14, 2017

Show outdated Hide outdated akka-http-core/src/main/mima-filters/10.0.10.backwards.excludes
Show outdated Hide outdated ...-http-core/src/main/scala/akka/http/impl/model/parser/HeaderParser.scala
case NonFatal(e) ErrorInfo.fromCompoundString(e.getMessage)
}
}
def ruleNotFound(ruleName: String): Result = HeaderParser.RuleNotFound

This comment has been minimized.

@raboof

raboof Sep 14, 2017

Member

👍 nice!

@raboof

raboof Sep 14, 2017

Member

👍 nice!

=htc replace usage of `RuleNotFoundException` by introducing explicit…
… result ADT

Before every attempt to parse an unknown (i.e. not modeled) header would
end up in throwing and catching an exception. This does not really make
sense as parboiled already provides for delivering these signals without
an exception.

Refs playframework/playframework#7822
@akka-ci

This comment has been minimized.

Show comment
Hide comment
@akka-ci

akka-ci Sep 18, 2017

Collaborator

Test PASSed.

Collaborator

akka-ci commented Sep 18, 2017

Test PASSed.

@jrudolph jrudolph merged commit 32071d8 into akka:master Sep 18, 2017

3 checks passed

Jenkins PR Validation Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@jrudolph jrudolph deleted the jrudolph:jr/w/remote-header-parser-RuleNotFoundException branch Sep 18, 2017

@jrudolph jrudolph added this to the 10.0.11 milestone Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment