Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change comments in CacheDirective to scaladoc #1514 #1521

Merged
merged 2 commits into from Nov 9, 2017
Merged

Change comments in CacheDirective to scaladoc #1514 #1521

merged 2 commits into from Nov 9, 2017

Conversation

tom-walford
Copy link
Contributor

  • Updated comments in CacheDirective to be scaladocs
  • Updated comments in HttpCookie to be scaladocs
  • Updated comments in LinkValue to be scaladocs

@tom-walford
Change comments in CacheDirective to scaladoc akka#1514
bfbd58a 
* Updated comments in CacheDirective to be scaladocs
* Updated comments in HttpCookie to be scaladocs
* Updated comments in LinkValue to be scaladocs
@akka-ci
Copy link

akka-ci commented Nov 8, 2017

Can one of the repo owners verify this patch?

jlprat
jlprat approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks a lot @tom-walford !

@jlprat
Copy link
Member

jlprat commented Nov 8, 2017

OK TO TEST

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels Nov 8, 2017
@akka-ci
Copy link

akka-ci commented Nov 8, 2017

Test FAILed.

@jlprat
Copy link
Member

jlprat commented Nov 8, 2017

Problem with the build is some formatting issues with the comments.
Just run sbt's compile task and you'll see it fixed locally. Then just push the changes

@tom-walford
Copy link
Contributor Author

Done - really like what you guys have done with the docs - the compiler checked code is really nice

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Nov 8, 2017
@akka-ci
Copy link

akka-ci commented Nov 8, 2017

Test FAILed.

@jlprat
Copy link
Member

jlprat commented Nov 8, 2017

Failure was #1502

PLS BUILD

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Nov 8, 2017
@akka-ci
Copy link

akka-ci commented Nov 8, 2017

Test PASSed.

jrudolph
jrudolph reviewed Nov 9, 2017
View reviewed changes
akka-http-core/src/main/scala/akka/http/scaladsl/model/headers/HttpCookie.scala
/**
* http://tools.ietf.org/html/rfc6265#section-4.1.1
* US-ASCII characters excluding CTLs, whitespace DQUOTE, comma, semicolon, and backslash
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so important here, but thanks anyway ;)

jrudolph
jrudolph approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrudolph jrudolph merged commit a5061c6 into akka:master Nov 9, 2017
@jrudolph
Copy link
Member

Refs #1514.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

@jlprat jlprat jlprat approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tom-walford @akka-ci @jlprat @jrudolph