New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement reverseProxy directive (#240) #2020
Conversation
@leachbj @2Beaucoup |
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged. For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask! |
837c189
to
2740cc9
Compare
OK TO TEST |
Test FAILed. |
Test FAILed. |
Is there a way to run |
Test FAILed. |
Does |
Is the current binary incompatibility failure on 2.11 OK? If not, why isn't it present on 2.12, and what's the right way to fix? |
Test FAILed. |
@kag0 We recommend people to import the directives with The Scala Java unfortunately does not have multiple inheritance like this, so instead we create a 'chain' of implementations all extending each other. To add your directives to the 'bottom of the chain' like in Scala, extend your new API's at https://github.com/akka/akka-http/blob/master/akka-http/src/main/scala/akka/http/javadsl/server/Directives.scala#L14, and have them extend the Does that make sense? |
(travis still catches a compile error when compiling with 2.11, btw https://travis-ci.org/akka/akka-http/builds/478845890#L639) |
fix 2.11 compile issues
That makes sense, took care of the 2.11 issue as well. |
Test FAILed. |
a0dc87f
to
1bc3759
Compare
Test FAILed. |
Test FAILed. |
Test FAILed. |
Closing due to inactivity - feel free to reopen when work on this continues! |
Looking back through here and it seems there's a lot of interest and even some SWIM using it in production. I should get back on the horse and get this merged. Where did we leave off? Seems like things should be compiling on 2.11, we have the java api, we might feel OK ignoring the MiMa error. Anything I'm missing? |
Work in progress to resolve #240
Lots of credit to #324
still need to
Via
header (how important is this actually for a first version?)