Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix LfuCache ttl can be equal to tti #2188
If you don't want to use tti you need to write some ugly
(Maybe if tti is not finite we should use ttl for both values. That would make easier setup in some use-cases. But that can be misleading too, so I did the minimal effort "fix" only.)
(Or maybe we should play with boolalgebra and change the whole thing to:
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.
For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!
The documentation currently states:
Time-based entry expiration is enabled when a time-to-live and/or time-to-idle expirations are set to a finite duration. The former provides an upper limit to the time period an entry is allowed to remain in the cache while the latter limits the maximum time an entry is kept without having been accessed, ie. either read or updated. If both values are finite the time-to-live has to be strictly greater than the time-to-idle.
Please update it to reflect the change by removing the last sentence.
Otherwise, I don't remember the motivation for