Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix CsvSeq unmarshaller to include trailing empty string values in the result Seq[T] #2249
This PR solves the issue when
val values = Await.result(CsvSeq[String].apply(",value1,value2,"), Duration.Inf) // Current behaviour assert(values == Seq("", "value1", "value2")) // Expected behaviour // assert(values == Seq("", "value1", "value2", ""))
This is my very first PR, so I am scared and sorry if I did something wrong, but the fix seems straightforward enough to try submitting it
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.
For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!
@raboof If you mean documentation for
We could add some samples (and tests) for custom types to be used in