Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix limiting of chunk size in the NoCoding encoder #2252
This fixes an issue where the limitByteChunksStage function used by the NoCoding encoder was losing data if larger than the maximum chunk size. The tests have also been fixed to cover this scenario.
I don't know if this is an issue that affects people using the akka-http in the wild, but is quite subtle. I came across the issue trying to test out chunked StreamRefs in akka-cluster in a WIP PR akka/akka#25643. That PR copies the broken code from akka-http verbatim, so is likely to be also broken.
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.
For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!