New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing HTTP Status Code 425 with TOO_EARLY #2255

Merged
merged 2 commits into from Oct 30, 2018

Conversation

Projects
None yet
5 participants
@Philippus
Copy link
Contributor

Philippus commented Oct 13, 2018

I think this should be safe to just replace as Unordered Collection was only ever present in WebDAV drafts and should have no implementations, but of course it is a breaking change.
See https://tools.ietf.org/html/rfc8470 for details on Too Early.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 13, 2018

Test FAILed.

@johanandren

This comment has been minimized.

Copy link
Member

johanandren commented Oct 15, 2018

Thanks, but we'll have to keep the existing name for binary compatibility, but I think it'd be fine to add an alias with the TooEarly and TOO_EARLY name (potentially deprecating the old one, so that we can remove it in the future).

You can read about the bin comp guarantees/requirements here: https://doc.akka.io/docs/akka/current/common/binary-compatibility-rules.html

@Philippus

This comment has been minimized.

Copy link
Contributor

Philippus commented Oct 17, 2018

Would something like this suffice?:

@deprecated("Non-standard Unordered Collection should not be used, deprecated in favor of Too Early", "10.1.6")
val UnorderedCollection = TooEarly
@johanandren

This comment has been minimized.

Copy link
Member

johanandren commented Oct 29, 2018

Yes, that's exactly what we'd need to do, and the same for Java. Sorry for not elaborating on that in the original feedback.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 29, 2018

Test PASSed.

@johanandren
Copy link
Member

johanandren left a comment

LGTM, thanks!

@jrudolph
Copy link
Member

jrudolph left a comment

LGTM

@jrudolph jrudolph merged commit 25f5eb1 into akka:master Oct 30, 2018

3 checks passed

Jenkins PR Validation Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@jrudolph jrudolph added this to the 10.0.15 milestone Oct 30, 2018

@Philippus Philippus deleted the Philippus:add-http-status-code-425 branch Oct 30, 2018

@raboof raboof modified the milestones: 10.0.15, 10.1.7 Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment