New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several warnings across all the modules #2292

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
5 participants
@jlprat
Copy link
Member

jlprat commented Nov 26, 2018

Fixes different types of warnings in the core, marshallers, http2, http and testkit projects

Fix several warnings across all the modules
Fixes different types of warnings in the core, marshallers, http2, http and testkit projects

@akka-ci akka-ci added the validating label Nov 26, 2018

@akka-ci akka-ci added tested and removed validating labels Nov 26, 2018

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 26, 2018

Test PASSed.

@raboof

raboof approved these changes Nov 27, 2018

Copy link
Member

raboof left a comment

👍

@jlprat jlprat added the 2 - pick next label Dec 6, 2018

@jrudolph
Copy link
Member

jrudolph left a comment

LGTM but didn't understand the deprecation of exceptNoMessage.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 6, 2018

Test PASSed.

jlprat added a commit to jlprat/akka that referenced this pull request Dec 6, 2018

Add forgotten `expectNoMessage` method in StreamTestKit
As discovered during akka/akka-http#2292 (comment) the parameterless version of `expectNoMessage` in StreamTestKit is missing.
@jrudolph
Copy link
Member

jrudolph left a comment

LGTM, thanks @jlprat.

@jlprat jlprat merged commit 284e9b9 into akka:master Dec 10, 2018

3 checks passed

Jenkins PR Validation Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@jlprat jlprat deleted the jlprat:fix-more-warnings branch Dec 10, 2018

@jlprat

This comment has been minimized.

Copy link
Member

jlprat commented Dec 10, 2018

Merged as it got 3 LGTM already

@jlprat jlprat added this to the 10.1.6 milestone Dec 10, 2018

patriknw added a commit to akka/akka that referenced this pull request Dec 12, 2018

Add forgotten `expectNoMessage` method in StreamTestKit (#26070)
* Add forgotten `expectNoMessage` method in StreamTestKit

As discovered during akka/akka-http#2292 (comment) the parameterless version of `expectNoMessage` in StreamTestKit is missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment