Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for scala 2.13.0-M5 #2298

Merged
merged 39 commits into from Feb 6, 2019

Conversation

Projects
None yet
4 participants
@raboof
Copy link
Member

commented Nov 29, 2018

Updated just akka-http-core on 2.12/2.13 for now.

Unfortunately we have a number of places where we have both a varargs and a immutable.Seq overload for the same method. This is no longer valid on 2.13.0, and the only way I could think of to solve this in a binary compatible way was a rather weird trick: introduce a VASeq type which corresponds to immutable.Seq on 2.12 and immutable.Iterable on 2.13 (to avoid the ambiguity but at the same time be mostly source-compatible and keep intact the fact that this value is immutable).

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Nov 29, 2018

Test FAILed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Nov 29, 2018

Test FAILed.

@jrudolph

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Unfortunately we have a number of places where we have both a varargs and a immutable.Seq overload for the same method. This is no longer valid on 2.13.0

Is that documented somewhere? Would be nice if no overload was necessary at all and the compiler would just accept a Seq in the first place even without the : _* type ascription.

We could also say that we don't keep source compatibility and remove the (Seq) overloads in 2.13 (and deprecate them in 2.12).

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Nov 29, 2018

Test FAILed.

@raboof

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2018

@jrudolph do you think we should only support the varargs variant for 2.13 and deprecate the Seq variant for all versions of scala? I guess we would still have to keep the VASeq as long as we support the deprecated methods, but we could drop the scala2.13 implementation and remove it entirely as soon as we have fulfilled the deprecation cycle for 2.12.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Dec 4, 2018

Test FAILed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Dec 4, 2018

Test FAILed.

@akka-ci akka-ci added validating and removed needs-attention labels Dec 4, 2018

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2019

Test PASSed.

jrudolph added some commits Feb 5, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2019

Test PASSed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Feb 6, 2019

Test PASSed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Feb 6, 2019

Test PASSed.

@jrudolph jrudolph merged commit 8f95ab0 into master Feb 6, 2019

4 checks passed

Jenkins PR Validation Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@jrudolph jrudolph deleted the scala-2.13.0-M5 branch Feb 6, 2019

franktominc added a commit to franktominc/akka-http that referenced this pull request Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.