New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Scala 2.12.8 #2305

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
4 participants
@jlprat
Copy link
Member

jlprat commented Dec 4, 2018

No description provided.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 4, 2018

Test FAILed.

@jlprat

This comment has been minimized.

Copy link
Member

jlprat commented Dec 4, 2018

Looks like we hit some non-backwards source compatibility in this release...

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 4, 2018

Test PASSed.

@raboof

raboof approved these changes Dec 4, 2018

@@ -130,7 +130,7 @@ class DebuggingDirectivesExamplesSpec extends RoutingSpec {
}
def printResponseTime(log: LoggingAdapter) = {
val requestTimestamp = System.nanoTime
akkaResponseTimeLoggingFunction(log, requestTimestamp)(_)
akkaResponseTimeLoggingFunction(log, requestTimestamp)_

This comment has been minimized.

@raboof

raboof Dec 4, 2018

Member

That's pretty obscure...

This comment has been minimized.

@jlprat

jlprat Dec 4, 2018

Member

Yes... I thought the same, luckily the error was telling what to do

@jrudolph
Copy link
Member

jrudolph left a comment

Seems 2.12.8 introduced some incompatibilities with Cinnamon / Lightbend Telemetry. Let's wait with updating to 2.12.8 until those have been resolved (especially with releasing).

@jlprat

This comment has been minimized.

Copy link
Member

jlprat commented Dec 5, 2018

OK, it makes sense. Are we planning to release soon?

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Dec 5, 2018

Looks like we hit some non-backwards source compatibility in this release...

I filed it as scala/bug#11289.

@jlprat

This comment has been minimized.

Copy link
Member

jlprat commented Dec 5, 2018

@jrudolph regarding the merge, a similar PR was merged in Akka (akka/akka#26039) is it also impacted by Cinnamon / Telemetry?

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Dec 5, 2018

@jrudolph regarding the merge, a similar PR was merged in Akka (akka/akka#26039) is it also impacted by Cinnamon / Telemetry?

Yep, that's where an issue was found. It might not affect akka-http but we don't know yet.

@jlprat

This comment has been minimized.

Copy link
Member

jlprat commented Dec 5, 2018

Yep, that's where an issue was found. It might not affect akka-http but we don't know yet.

Thanks for the heads up!

@jlprat

This comment has been minimized.

Copy link
Member

jlprat commented Dec 10, 2018

Now that Akka was released with 2.12.8, is it fine for this PR to go through? cc @jrudolph

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Dec 11, 2018

Now that Akka was released with 2.12.8, is it fine for this PR to go through? cc @jrudolph

Yep, would think so.

@jrudolph jrudolph merged commit c76af33 into akka:master Dec 11, 2018

3 checks passed

Jenkins PR Validation Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@jlprat jlprat deleted the jlprat:scala-2.12.8 branch Dec 11, 2018

@raboof raboof added this to the 10.1.6 milestone Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment