Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `endsWith` predicate to `Uri.Path` #2480

Merged
merged 3 commits into from Jul 25, 2019

Conversation

@sirthias
Copy link
Contributor

commented Mar 22, 2019

Adds a small helper function that I would have liked to use myself.

This time I was looking for a Java API equivalent but I believe there is none for this part of the model, is there?

@akka-ci akka-ci added validating tested and removed validating labels Mar 22, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Mar 22, 2019

Test PASSed.

Copy link
Member

left a comment

LGTM

@raboof
raboof approved these changes Jul 9, 2019
Copy link
Member

left a comment

Nice - unfortunately there seems to be a merge conflict. Should we also add it to the docs somewhere?

Copy link
Member

left a comment

LGTM

@jrudolph jrudolph added this to the 10.1.10 milestone Jul 25, 2019
@jrudolph

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Thanks, @sirthias, and sorry for keeping it around for so long.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

Test FAILed.

Akka Jenkins
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

Test PASSed.

@sirthias

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Thank you, @jrudolph, and sorry, @raboof, for not reacting earlier.
I somehow missed your comment re the merge conflict.
I'll push a fix later today..

@jrudolph

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Already merged it ;)

@sirthias

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

@jrudolph, ah right. Even better! :)

@sirthias sirthias closed this Jul 25, 2019
@jrudolph jrudolph reopened this Jul 25, 2019
@jrudolph jrudolph merged commit 294924d into master Jul 25, 2019
2 of 5 checks passed
2 of 5 checks passed
typesafe-cla-validator At least one pull request committer is not linked to a user.
Details
Jenkins PR Validation Build triggered for merge commit.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Jenkins PR Auto-Formatter Successful
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jrudolph jrudolph deleted the md/path-endswith branch Jul 25, 2019
@akka-ci akka-ci added validating and removed tested labels Jul 25, 2019
@akka akka deleted a comment from lightbend-cla-validator Jul 25, 2019
@akka akka deleted a comment from lightbend-cla-validator Jul 25, 2019
@akka-ci akka-ci added tested and removed validating labels Jul 25, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.