Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging unsupported content type #2512

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@raboof
Copy link
Member

commented Apr 23, 2019

Rebased/formatted version of #1713

Refs #1691

@akka-ci akka-ci added validating tested and removed validating labels Apr 23, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Apr 23, 2019

Test PASSed.

Copy link
Member

left a comment

A few things left but otherwise looking good.

}
} else FastFuture.failed(Unmarshaller.UnsupportedContentTypeException(supported))
rec(0, Set.empty)
Unmarshaller.withMaterializer { implicit ec

This comment has been minimized.

Copy link
@jrudolph

jrudolph May 14, 2019

Member

Can we keep the old formatting here as well?

@raboof raboof force-pushed the logUnsupportedContentType2 branch from 3e8aece to d878c99 Jul 9, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Test FAILed.

@raboof raboof force-pushed the logUnsupportedContentType2 branch from d878c99 to b29f2c0 Jul 9, 2019
@akka-ci akka-ci added validating and removed needs-attention labels Jul 9, 2019
@raboof raboof force-pushed the logUnsupportedContentType2 branch from b29f2c0 to 101fb8d Jul 9, 2019
@akka-ci akka-ci added tested and removed validating labels Jul 9, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Test PASSed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Test PASSed.

Rebased/formatted version of #1713
@raboof raboof force-pushed the logUnsupportedContentType2 branch from 101fb8d to d06ad69 Aug 14, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

Test PASSed.

@raboof raboof force-pushed the logUnsupportedContentType2 branch from d06ad69 to 897fa05 Aug 14, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

Test FAILed.

@raboof

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

PLS BUILD

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

Test PASSed.

Copy link
Member

left a comment

LGTM. WDYT, @raboof, should we merge it now or wait for 10.2.0? Since there are no binary incompatibilities left, maybe it's good for 10.1.10?

@raboof

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

Since there are no binary incompatibilities left, maybe it's good for 10.1.10?

Yes sounds good to me 👍

@jrudolph jrudolph merged commit 82b5057 into master Sep 9, 2019
5 checks passed
5 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 4165 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph deleted the logUnsupportedContentType2 branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.