Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate http2 switches and instantiation code in Http2 #2557

Merged
merged 5 commits into from Jun 6, 2019

Conversation

@jrudolph
Copy link
Member

commented Jun 5, 2019

A slight downside is that the plaintext layers will use some extra wrapping and unwrapping into TLS types but that's consistent with what the Http/1.1 side also does.

@jrudolph jrudolph requested review from viktorklang and raboof Jun 5, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

Test FAILed.

@viktorklang
Copy link
Member

left a comment

Great work, @jrudolph—lgtm!

@jrudolph jrudolph force-pushed the jrudolph:jr/review-http-prior-knowledge branch 2 times, most recently from a730325 to 6164fd8 Jun 6, 2019

@jrudolph

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

The failure was a legitimate failure that was previously masked by a timeout in H2SpecIntegrationSpec. I added a few commits fixing and adding to the tests.

@akka-ci akka-ci added validating and removed needs-attention labels Jun 6, 2019

@akka-ci akka-ci added tested and removed validating labels Jun 6, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Test PASSed.

jrudolph added some commits Jun 5, 2019

@jrudolph jrudolph force-pushed the jrudolph:jr/review-http-prior-knowledge branch from 6164fd8 to 7b12b5b Jun 6, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Test PASSed.

@jrudolph jrudolph force-pushed the jrudolph:jr/review-http-prior-knowledge branch from 7b12b5b to 0a707d9 Jun 6, 2019

@akka-ci akka-ci added the validating label Jun 6, 2019

@akka-ci akka-ci added tested and removed tested validating labels Jun 6, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Test PASSed.

@jrudolph jrudolph force-pushed the jrudolph:jr/review-http-prior-knowledge branch from 00b6095 to ade8665 Jun 6, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Test PASSed.

@jrudolph jrudolph merged commit 8b2afcb into akka:master Jun 6, 2019

4 checks passed

Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 1610 tests run, 976 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@jrudolph jrudolph deleted the jrudolph:jr/review-http-prior-knowledge branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.