Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ht2 add akka.http.server.http2.log-frames for verbose frame logging for debugging purposes #2561

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@jrudolph
Copy link
Member

commented Jun 6, 2019

  • enable it for some test suites which use WithLogCapturing
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Test FAILed.

@jrudolph jrudolph force-pushed the jrudolph:jr/add-http2-frame-logging branch from 8f8f232 to c714f0b Jun 6, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Test PASSed.

+ht2 add akka.http.server.http2.log-frames for verbose frame logging …
…for debugging purposes

+ enable it for some test suites which use WithLogCapturing

@jrudolph jrudolph force-pushed the jrudolph:jr/add-http2-frame-logging branch from c714f0b to a517325 Jul 3, 2019

@jrudolph

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

Missing mima ignore for 2.11, now fixed.

@jrudolph jrudolph requested a review from raboof Jul 3, 2019

@akka-ci akka-ci added validating and removed tested labels Jul 3, 2019

@raboof

raboof approved these changes Jul 3, 2019

Copy link
Member

left a comment

I agree this could be nice for debugging! On my local machine I'd probably usually still prefer unencrypted HTTP/2 and wireshark - it can nicely display the frames as well.

@akka-ci akka-ci added tested and removed validating labels Jul 3, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

Test PASSed.

@jrudolph jrudolph merged commit e0841eb into akka:master Jul 3, 2019

4 checks passed

Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 4146 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@jrudolph jrudolph deleted the jrudolph:jr/add-http2-frame-logging branch Jul 3, 2019

@jrudolph jrudolph added this to the 10.1.9 milestone Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.