Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug that caused the library to use a https connection pool for http connections (#857) #2562

Merged
merged 2 commits into from Jul 4, 2019

Conversation

@lhotari
Copy link
Contributor

commented Jun 6, 2019

Purpose

Fixes a bug that caused the library to use a https connection pool for http connections.

  • besides the misbehavior, it was not possible to configure a
    plain http connection pool. That is now possible too.
    This bug has been reported as #857 a long time ago. The issue report has more details.

References

References #857

Fix bug that uses https conn pool for http conns (#857)
- besides the misbehavior, it was not possible to configure a
  plain http connection pool. See #857 for more details.

Signed-off-by: Lari Hotari <lari@hotari.net>
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@raboof

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

OK TO TEST

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

Test FAILed.

Akka Jenkins
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

Test PASSed.

@lhotari

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@raboof Could you please review this change and provide feedback? This should be a quick one...

@raboof

raboof approved these changes Jun 20, 2019

Copy link
Member

left a comment

Indeed it seems a javadsl cachedHostConnectionPool that supported passing in connection pool settings was missing

@jrudolph
Copy link
Member

left a comment

LGTM

@jrudolph jrudolph merged commit 10574f3 into akka:master Jul 4, 2019

4 checks passed

Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 4138 tests run, 1072 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.