Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen JavaUUID regexp's #2624

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@Philippus
Copy link
Contributor

Philippus commented Jul 31, 2019

Purpose

Widen JavaUUID regex's (again) to allow for old and future variants of uuid's (described in chapter 4.1.1 of RFC 4122.

References

Following-up after #2569 and #2596. Thanks to @plokhotnyuk for pointing this out in spray/spray-json#313.

@akka-ci akka-ci added validating tested and removed validating labels Jul 31, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Jul 31, 2019

Test PASSed.

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Jul 31, 2019

Could you add a few tests for those newly allowed UUIDs so that we can see that UUID.fromString will also accept them? Otherwise, we might want to add the try/catch again.

@Philippus Philippus force-pushed the Philippus:widen-uuid-regexp branch from ea8b9bf to 223b0bc Jul 31, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Jul 31, 2019

Test PASSed.

Copy link
Member

jrudolph left a comment

Thanks @Philippus. LGTM

@jrudolph jrudolph merged commit 2361b16 into akka:master Aug 1, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 4162 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph added this to the 10.1.10 milestone Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.