Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling on server when response entity stream fails #2627

Merged

Conversation

@jrudolph
Copy link
Member

commented Jul 31, 2019

I.e.

  • when materializing the response entity stream fails: return a 500 response
  • when streaming itself fails: abort the connection

Refs #848, #894.

Refs #848
@akka-ci akka-ci added the validating label Jul 31, 2019
@jrudolph jrudolph requested a review from raboof Jul 31, 2019
@akka-ci akka-ci added tested and removed validating labels Jul 31, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 31, 2019

Test PASSed.

@raboof
raboof approved these changes Aug 5, 2019
Copy link
Member

left a comment

Much clearer!

@jrudolph jrudolph force-pushed the jrudolph:jr/848-log-error-on-response-stream-failure branch from e7b99b9 to 44147a6 Aug 6, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

Test PASSed.

@jrudolph jrudolph merged commit fd201c5 into akka:master Aug 6, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 4164 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph deleted the jrudolph:jr/848-log-error-on-response-stream-failure branch Aug 6, 2019
jrudolph added a commit that referenced this pull request Aug 14, 2019
Fix performance regression introduced in #2627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.